From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Chen Yuanquan-B41889 <B41889@freescale.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Yuanquan Chen <Yuanquan.Chen@freescale.com>,
Hiroo Matsumoto <matsumoto.hiroo@jp.fujitsu.com>
Subject: Re: [PATCH] powerpc/pci: Improve device hotplug initialization
Date: Thu, 06 Jun 2013 15:44:14 +1000 [thread overview]
Message-ID: <1370497454.3766.267.camel@pasglop> (raw)
In-Reply-To: <20130606052508.GA1901@roeck-us.net>
On Wed, 2013-06-05 at 22:25 -0700, Guenter Roeck wrote:
>
>
> Can you point me to some of the breaking code ? I guess it must be in some of
> the pci_dma_dev_setup callbacks, but those I looked at only check devicetree
> data or simply set function pointers, both of which should not be affected by
> the call order.
>
> How about pcibios_fixup_device, to be called after pcibios_fixup_bus ?
Mostly the pseries ones from a cursory glance. They could be improved to
be agnostic to the call order I suppose or simply done better but heh...
I like using pcibios_add though ... we just need to figure out how to
sort out that ordering if possible.
Cheers,
Ben.
prev parent reply other threads:[~2013-06-06 5:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:35 [PATCH] powerpc/pci: Improve device hotplug initialization Guenter Roeck
2013-05-29 9:30 ` Chen Yuanquan-B41889
2013-05-31 5:14 ` Guenter Roeck
2013-05-31 5:44 ` Benjamin Herrenschmidt
2013-06-01 13:58 ` Guenter Roeck
2013-06-03 2:28 ` Chen Yuanquan-B41889
2013-06-03 4:11 ` Guenter Roeck
2013-06-06 1:00 ` Benjamin Herrenschmidt
2013-06-06 5:25 ` Guenter Roeck
2013-06-06 5:44 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370497454.3766.267.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B41889@freescale.com \
--cc=Yuanquan.Chen@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matsumoto.hiroo@jp.fujitsu.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox