From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753412Ab3FLEsa (ORCPT ); Wed, 12 Jun 2013 00:48:30 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:34347 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750968Ab3FLEs3 (ORCPT ); Wed, 12 Jun 2013 00:48:29 -0400 Message-ID: <1371012507.2069.4.camel@joe-AO722> Subject: Re: [checkpatch] - Confusion From: Joe Perches To: =?ISO-8859-1?Q?S=F6ren?= Brinkmann Cc: PINTU KUMAR , Andy Whitcroft , anish singh , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Date: Tue, 11 Jun 2013 21:48:27 -0700 In-Reply-To: <1371010505.2069.3.camel@joe-AO722> References: <1370843475.58124.YahooMailNeo@web160106.mail.bf1.yahoo.com> <1370890140.99216.YahooMailNeo@web160102.mail.bf1.yahoo.com> <8a2ec29d-e6d8-44ed-a70d-2273848706ce@VA3EHSMHS029.ehs.local> <1371010505.2069.3.camel@joe-AO722> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-06-11 at 21:15 -0700, Joe Perches wrote: > > typedef struct ctl_table ctl_table; (include/linux/sysctl.h) > > is not correctly picked up by checkpatch. > > checkpatch isn't a c compiler. > It assumes any _t is a typedef. > > > So, I assume this actually is a false positive. > > Yup. Another option is to use "struct ctl_table" instead of bare ctl_table.