From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Parisc List <linux-parisc@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND] fix WARNING: at kernel/cpu/idle.c:96
Date: Fri, 14 Jun 2013 12:13:12 -0700 [thread overview]
Message-ID: <1371237192.2726.46.camel@dabdike> (raw)
In-Reply-To: <51BB6AE3.8030903@gmail.com>
On Fri, 2013-06-14 at 12:11 -0700, David Daney wrote:
> On 06/14/2013 11:55 AM, James Bottomley wrote:
> >>From 48bbf44a96676ce6f520a408378730c976e9a11e Mon Sep 17 00:00:00 2001
> > From: James Bottomley <JBottomley@Parallels.com>
> > Date: Wed, 8 May 2013 14:05:34 -0700
> > Subject: [PATCH] [PARISC] fix WARNING: at kernel/cpu/idle.c:96
> >
> > On PA-RISC (and presumably any other arch that doesn't implement its own
> > arch_cpu_idle), we get this spurious boot warning. The problem is that the
> > way the idle task is selected initially using the weak arch_cpu_idle() in
> > idle.c causes us to enter this place once with interrupts enabled. Fix this
> > by disabling interrupts in the weak arch_cpu_idle() code.
>
> Is this changelog correct? It looks to me like you are enabling
> interrupts down there.
Yes, obvious typo, sorry. The WARN_ON check is for disabled interrupts
the fix is to enable them.
James
next prev parent reply other threads:[~2013-06-14 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 18:55 [PATCH RESEND] fix WARNING: at kernel/cpu/idle.c:96 James Bottomley
2013-06-14 19:11 ` David Daney
2013-06-14 19:13 ` James Bottomley [this message]
2013-06-14 20:39 ` Thomas Gleixner
2013-06-14 20:49 ` Thomas Gleixner
2013-06-14 21:50 ` James Bottomley
2013-06-19 7:03 ` [tip:core/urgent] idle: Enable interrupts in the weak arch_cpu_idle() implementation tip-bot for James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371237192.2726.46.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=ddaney.cavm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).