From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753358AbbCLKYV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Mar 2015 06:24:21 -0400
Received: from gloria.sntech.de ([95.129.55.99]:49691 "EHLO gloria.sntech.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750726AbbCLKYS convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Mar 2015 06:24:18 -0400
From: Heiko Stuebner <heiko@sntech.de>
To: linux-mediatek@lists.infradead.org, CK Hu <ck.hu@mediatek.com>
Cc: Paul Bolle <pebolle@tiscali.nl>, Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, Jitao Shi <jitao.shi@mediatek.com>,
        Sascha Hauer <kernel@pengutronix.de>, srv_heupstream@mediatek.com,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH 2/2] drm/bridge: Add IT6151 bridge driver
Date: Thu, 12 Mar 2015 11:24:10 +0100
Message-ID: <13714812.stPyeO78Dq@phil>
User-Agent: KMail/4.14.1 (Linux/3.19.0+; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1426150847.5304.22.camel@x220>
References: <1426054733-54378-1-git-send-email-ck.hu@mediatek.com> <1426054733-54378-2-git-send-email-ck.hu@mediatek.com> <1426150847.5304.22.camel@x220>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Donnerstag, 12. März 2015, 10:00:47 schrieb Paul Bolle:
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/it6151.c
> > 
> > +#include <linux/module.h>
> 
> This file can only be built-in. So I couldn't help but notice this
> include. And if I remove it
>     make drivers/gpu/drm/bridge/it6151.o
> 
> still runs without warning or errors. Unless I've missed something
> non-obvious I'd say it is not needed.

I think the more interesting question would be, why can it only be built in 
:-) .

The drm/bridge series from Ajay Kumar [0] made it into 4.0-rc that enables 
drm-bridges to be regular platform/i2c devices, see [1] for example.

So I think any new bridge driver should use this approach and can thus also be 
build as module.


Heiko


[0] http://www.spinics.net/lists/linux-samsung-soc/msg41403.html
[1] http://www.spinics.net/lists/linux-samsung-soc/msg41406.html