public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: Li Wang <liwang@ubuntukylin.com>
Cc: Sage Weil <sage@inktank.com>,
	ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yunchuan Wen <yunchuanwen@ubuntukylin.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] Ceph: Punch hole support
Date: Thu, 20 Jun 2013 15:56:38 -0500	[thread overview]
Message-ID: <1371761798.2776.134@driftwood> (raw)
In-Reply-To: <51C1DB17.6040803@ubuntukylin.com> (from liwang@ubuntukylin.com on Wed Jun 19 11:23:51 2013)

On 06/19/2013 11:23:51 AM, Li Wang wrote:
> This patch implements punch hole (fallocate) support for Ceph.
> 
> Signed-off-by: Li Wang <liwang@ubuntukylin.com>
> Signed-off-by: Yunchuan Wen <wenyunchuan@ubuntukylin.com>

> +static int ceph_delete_object(struct inode *inode, u64 offset, u64  
> *length)
> +{
> +	struct ceph_inode_info *ci = ceph_inode(inode);
> +    struct ceph_fs_client *fsc = ceph_inode_to_client(inode);	
> +	struct ceph_osd_request *req;

Mixing tabs and spaces.


> +static int ceph_punch_hole(struct file *file, loff_t offset, loff_t  
> length)
> +{
> +	struct inode *inode = file->f_dentry->d_inode;
> +	int ret = 0;
> +
> +    if (!S_ISREG(inode->i_mode)) {
> +        return -EOPNOTSUPP;
> +	}

And again.

Rob

  parent reply	other threads:[~2013-06-21  3:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 15:36 [PATCH 0/2] Kernel file system client support for punch hole Li Wang
2013-06-14 15:38 ` [PATCH 1/2] Punch hole support against 3.8-rc3 Li Wang
2013-06-14 15:39 ` [PATCH 2/2] Punch hole support against 3.10-rc5 Li Wang
2013-06-14 16:27   ` Sage Weil
2013-06-19 16:23     ` [PATCH v2] Ceph: Punch hole support Li Wang
2013-06-19 16:31       ` Sage Weil
2013-06-20  3:18         ` Dave Chinner
2013-06-20 20:56       ` Rob Landley [this message]
2013-07-22 13:02         ` [PATCH v3] Ceph: Punch hole support for kernel client Li Wang
2013-06-14 16:02 ` [PATCH 0/2] Kernel file system client support for punch hole Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371761798.2776.134@driftwood \
    --to=rob@landley.net \
    --cc=ceph-devel@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwang@ubuntukylin.com \
    --cc=sage@inktank.com \
    --cc=yunchuanwen@ubuntukylin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox