From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com,
Hugh Dickins <hughd@google.com>
Subject: [PATCH 3/8] perf,x86: add uvirt_to_phys_nmi helper function
Date: Fri, 21 Jun 2013 16:20:43 +0200 [thread overview]
Message-ID: <1371824448-7306-4-git-send-email-eranian@google.com> (raw)
In-Reply-To: <1371824448-7306-1-git-send-email-eranian@google.com>
Function to convert from a user level address to its
physical address. To be used by perf_events memory
access sampling feature.
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Stephane Eranian <eranian@google.com>
---
arch/x86/include/asm/uaccess.h | 1 +
arch/x86/lib/usercopy.c | 43 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+)
diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
index 5ee2687..4c9a102 100644
--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -513,6 +513,7 @@ struct __large_struct { unsigned long buf[100]; };
extern unsigned long
copy_from_user_nmi(void *to, const void __user *from, unsigned long n);
+extern phys_addr_t uvirt_to_phys_nmi(const void __user *address);
extern __must_check long
strncpy_from_user(char *dst, const char __user *src, long count);
diff --git a/arch/x86/lib/usercopy.c b/arch/x86/lib/usercopy.c
index 4f74d94..3f19023 100644
--- a/arch/x86/lib/usercopy.c
+++ b/arch/x86/lib/usercopy.c
@@ -47,3 +47,46 @@ copy_from_user_nmi(void *to, const void __user *from, unsigned long n)
return len;
}
EXPORT_SYMBOL_GPL(copy_from_user_nmi);
+
+/*
+ * Best effort, NMI-safe GUP-fast-based user-virtual to physical translation.
+ *
+ * Does not really belong in "usercopy.c", but kept here for comparison with
+ * copy_from_user_nmi() above.
+ *
+ * __get_user_pages_fast() may fail at awkward moments e.g. while transparent
+ * hugepage is being split. And at present it happens to SetPageReferenced():
+ * not really a problem when this is used for profiling pages which are being
+ * referenced, but should be fixed if this were to be used any more widely.
+ *
+ * At time of writing, __get_user_pages_fast() is supported by mips, s390, sh
+ * and x86 (with a weak fallback returning 0 on other architectures): we have
+ * not established whether it is NMI-safe on any other architecture than x86.
+ */
+phys_addr_t uvirt_to_phys_nmi(const void __user *address)
+{
+ unsigned long vaddr = (unsigned long)address;
+ phys_addr_t paddr = vaddr & ~PAGE_MASK;
+ struct page *page;
+
+ if (!current->mm)
+ return -1;
+
+ if (__range_not_ok(address, 1, TASK_SIZE))
+ return -1;
+
+ if (!__get_user_pages_fast(vaddr, 1, 0, &page))
+ return -1;
+
+ paddr += (phys_addr_t)page_to_pfn(page) << PAGE_SHIFT;
+
+ /*
+ * If called under NMI, this put_page(page) cannot be its final
+ * put_page (which would indeed be problematic): a racing munmap
+ * on another CPU cannot free the page until it has flushed TLB
+ * on our CPU, and that must wait for us to leave NMI.
+ */
+ put_page(page);
+
+ return paddr;
+}
--
1.8.1.2
next prev parent reply other threads:[~2013-06-21 14:21 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 14:20 [PATCH 0/8] perf: add ability to sample physical data addresses Stephane Eranian
2013-06-21 14:20 ` [PATCH 1/8] perf,x86: disable PEBS-LL in intel_pmu_pebs_disable() Stephane Eranian
2013-06-24 8:44 ` Peter Zijlstra
2013-06-26 7:35 ` Stephane Eranian
2013-06-27 9:01 ` [tip:perf/core] perf/x86: Disable " tip-bot for Stephane Eranian
2013-06-21 14:20 ` [PATCH 2/8] perf,x86: drop event->flags and use hw.constraint->flags Stephane Eranian
2013-06-24 8:45 ` Peter Zijlstra
2013-06-26 7:36 ` Stephane Eranian
2013-06-26 10:36 ` Peter Zijlstra
2013-06-27 10:23 ` Stephane Eranian
2013-06-27 10:48 ` Peter Zijlstra
2013-06-27 11:01 ` Stephane Eranian
2013-06-27 11:14 ` Peter Zijlstra
2013-06-27 12:33 ` Stephane Eranian
2013-06-27 14:10 ` Peter Zijlstra
2013-06-21 14:20 ` Stephane Eranian [this message]
2013-06-21 14:20 ` [PATCH 4/8] perf: add PERF_SAMPLE_PHYS_ADDR sample type Stephane Eranian
2013-06-21 14:20 ` [PATCH 5/8] perf,x86: add support for PERF_SAMPLE_PHYS_ADDR for PEBS-LL Stephane Eranian
2013-06-21 14:20 ` [PATCH 6/8] perf tools: add infrastructure to handle PERF_SAMPLE_PHYS_ADDR Stephane Eranian
2013-06-21 14:20 ` [PATCH 7/8] perf record: add option to sample physical load/store addresses Stephane Eranian
2013-06-21 14:20 ` [PATCH 8/8] perf mem: add physical addr sampling support Stephane Eranian
2013-06-23 21:58 ` [PATCH 0/8] perf: add ability to sample physical data addresses Jiri Olsa
2013-06-24 8:16 ` Stephane Eranian
2013-06-24 8:45 ` Jiri Olsa
2013-06-24 8:43 ` Peter Zijlstra
2013-06-25 9:59 ` Stephane Eranian
2013-06-25 10:47 ` Peter Zijlstra
2013-06-25 10:51 ` Ingo Molnar
2013-06-26 10:33 ` Peter Zijlstra
2013-06-26 19:10 ` Stephane Eranian
2013-06-28 9:58 ` Peter Zijlstra
2013-07-05 22:48 ` Stephane Eranian
2013-07-08 8:19 ` Peter Zijlstra
2013-07-09 6:02 ` Stephane Eranian
2013-07-30 8:02 ` Stephane Eranian
2013-07-30 8:37 ` Peter Zijlstra
2013-07-30 8:51 ` Stephane Eranian
2013-07-30 9:02 ` Peter Zijlstra
2013-07-30 13:09 ` Stephane Eranian
2013-07-30 14:21 ` Stephane Eranian
2013-07-30 14:50 ` David Ahern
2013-07-30 14:53 ` Stephane Eranian
2013-07-30 14:59 ` David Ahern
2013-07-30 15:52 ` Peter Zijlstra
2013-07-30 16:09 ` Stephane Eranian
2013-07-30 16:16 ` Peter Zijlstra
2013-06-26 13:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371824448-7306-4-git-send-email-eranian@google.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=hughd@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox