* [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error
@ 2013-06-23 0:48 Axel Lin
2013-06-23 8:26 ` Heiko Stübner
2013-06-24 12:26 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-06-23 0:48 UTC (permalink / raw)
To: Linus Walleij; +Cc: Heiko Stuebner, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 427564f..1eb5a2e 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1035,6 +1035,7 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
polarity &= ~mask;
break;
default:
+ irq_gc_unlock(gc);
return -EINVAL;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error
2013-06-23 0:48 [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error Axel Lin
@ 2013-06-23 8:26 ` Heiko Stübner
2013-06-24 12:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2013-06-23 8:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, linux-kernel
Am Sonntag, 23. Juni 2013, 02:48:34 schrieb Axel Lin:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks for catching this glitch.
Acked-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index 427564f..1eb5a2e 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1035,6 +1035,7 @@ static int rockchip_irq_set_type(struct irq_data *d,
> unsigned int type) polarity &= ~mask;
> break;
> default:
> + irq_gc_unlock(gc);
> return -EINVAL;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error
2013-06-23 0:48 [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error Axel Lin
2013-06-23 8:26 ` Heiko Stübner
@ 2013-06-24 12:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-06-24 12:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Heiko Stuebner, linux-kernel@vger.kernel.org
On Sun, Jun 23, 2013 at 2:48 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Excellent catch (as always).
Patch applied with Heiko's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-24 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-23 0:48 [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error Axel Lin
2013-06-23 8:26 ` Heiko Stübner
2013-06-24 12:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox