From: Darren Hart <dvhart@linux.intel.com>
To: zhang.yi20@zte.com.cn
Cc: linux-kernel@vger.kernel.org, Mel Gorman <mgorman@suse.de>,
"'Ingo Molnar'" <mingo@kernel.org>,
"'Peter Zijlstra'" <peterz@infradead.org>,
"'Thomas Gleixner'" <tglx@linutronix.de>,
Zhang Yi <wetpzy@gmail.com>
Subject: Re: Re: [PATCH] futex: bugfix for futex-key conflict when futex use hugepage
Date: Mon, 24 Jun 2013 14:02:17 -0700 [thread overview]
Message-ID: <1372107737.7914.27.camel@envy.home> (raw)
In-Reply-To: <OF7A810108.AA9BB6C1-ON48257B6D.000A1424-48257B6D.000B1EC6@zte.com.cn>
On Thu, 2013-05-16 at 10:00 +0800, zhang.yi20@zte.com.cn wrote:
>
> Darren Hart <dvhart@linux.intel.com> wrote on 2013/05/16 09:30:31:
>
> >
> > pgoff_t is an unsigned long, and page_to_pfn() returns an unsigned long.
> > Since compound_idx can be assigned from page_to_pfn() and it is added
> > with index in the return value, unsigned long seems like a better choice
> > to me. Is there a specific reason you prefer an int? It might be "fine"
> > but it is likely to raise eyebrows whenever someone read through it.
> >
> No other specific reason. I just think that int is enough.
Hi Yi,
I believe this patch is still pending a final version from you. Mel and
I both asked after the change of compound_idx from int to unsigned long.
While "int" may be adequate, for consistency with the return type
assigned and such, the unsigned long is preferred. Could you respin and
send along the patch so Thomas can pull it in?
Thanks,
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
next prev parent reply other threads:[~2013-06-24 21:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 13:57 [PATCH] futex: bugfix for futex-key conflict when futex use hugepage Zhang Yi
2013-05-15 14:20 ` Mel Gorman
2013-05-16 1:16 ` zhang.yi20
2013-05-16 1:30 ` Darren Hart
2013-05-16 2:00 ` zhang.yi20
2013-06-24 21:02 ` Darren Hart [this message]
2013-06-25 13:19 ` Zhang Yi
2013-06-25 18:23 ` Darren Hart
2013-06-25 19:41 ` Thomas Gleixner
2013-06-25 21:15 ` [tip:core/locking] futex: Take hugepages into account when generating futex_key tip-bot for Zhang Yi
-- strict thread matches above, loose matches on Subject: below --
2013-04-26 12:13 [PATCH] futex: bugfix for futex-key conflict when futex use hugepage Zhang Yi
2013-04-26 18:26 ` Thomas Gleixner
2013-05-07 12:23 ` Zhang Yi
2013-05-07 15:20 ` Mel Gorman
2013-05-10 9:08 ` zhang.yi20
2013-05-10 9:42 ` Mel Gorman
2013-04-16 18:37 Dave Hansen
2013-04-17 7:47 ` zhang.yi20
2013-04-16 17:57 Darren Hart
2013-04-17 9:55 ` zhang.yi20
2013-04-17 14:18 ` Darren Hart
2013-04-17 15:26 ` Dave Hansen
2013-04-17 15:51 ` Darren Hart
2013-04-18 8:05 ` zhang.yi20
2013-04-18 14:34 ` Darren Hart
2013-04-19 2:13 ` zhang.yi20
2013-04-19 2:45 ` Darren Hart
2013-04-19 7:03 ` zhang.yi20
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372107737.7914.27.camel@envy.home \
--to=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wetpzy@gmail.com \
--cc=zhang.yi20@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).