* Multiple DA9055 chips
@ 2013-07-01 16:48 Mark Brown
2013-07-02 9:31 ` Ashish Chavan
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2013-07-01 16:48 UTC (permalink / raw)
To: David Dajun Chen, Ashish Chavan, Ashish Jangam
Cc: alsa-devel, linux-kernel, Samuel Ortiz, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
It seems we have two drivers in mainline for da9055 on I2C. We've got
one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c,
both registering themselves identically. What's going on here? Is this
a combined CODEC and PMIC, has someone decided to release two chips with
the same name or is one of the drivers misnamed?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multiple DA9055 chips
2013-07-01 16:48 Multiple DA9055 chips Mark Brown
@ 2013-07-02 9:31 ` Ashish Chavan
2013-07-02 9:31 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Ashish Chavan @ 2013-07-02 9:31 UTC (permalink / raw)
To: Mark Brown
Cc: David Dajun Chen, Ashish Jangam, alsa-devel, linux-kernel,
Samuel Ortiz, Lee Jones
On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
> It seems we have two drivers in mainline for da9055 on I2C. We've got
> one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c,
> both registering themselves identically. What's going on here? Is this
> a combined CODEC and PMIC, has someone decided to release two chips with
> the same name or is one of the drivers misnamed?
Yes, this is a combined CODEC and PMIC.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multiple DA9055 chips
2013-07-02 9:31 ` Ashish Chavan
@ 2013-07-02 9:31 ` Mark Brown
2013-07-02 10:02 ` Ashish Chavan
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2013-07-02 9:31 UTC (permalink / raw)
To: Ashish Chavan
Cc: David Dajun Chen, Ashish Jangam, alsa-devel, linux-kernel,
Samuel Ortiz, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Tue, Jul 02, 2013 at 03:01:53PM +0530, Ashish Chavan wrote:
> On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
> > It seems we have two drivers in mainline for da9055 on I2C. We've got
> > one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c,
> > both registering themselves identically. What's going on here? Is this
> > a combined CODEC and PMIC, has someone decided to release two chips with
> > the same name or is one of the drivers misnamed?
> Yes, this is a combined CODEC and PMIC.
OK, in that case the CODEC driver is just plain broken then. Did anyone
actually test this stuff? Please fix.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multiple DA9055 chips
2013-07-02 9:31 ` Mark Brown
@ 2013-07-02 10:02 ` Ashish Chavan
2013-07-02 10:31 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Ashish Chavan @ 2013-07-02 10:02 UTC (permalink / raw)
To: Mark Brown
Cc: David Dajun Chen, Ashish Jangam, alsa-devel, linux-kernel,
Samuel Ortiz, Lee Jones
On Tue, 2013-07-02 at 10:31 +0100, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 03:01:53PM +0530, Ashish Chavan wrote:
> > On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
> > > It seems we have two drivers in mainline for da9055 on I2C. We've got
> > > one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c,
> > > both registering themselves identically. What's going on here? Is this
> > > a combined CODEC and PMIC, has someone decided to release two chips with
> > > the same name or is one of the drivers misnamed?
>
> > Yes, this is a combined CODEC and PMIC.
>
> OK, in that case the CODEC driver is just plain broken then. Did anyone
> actually test this stuff? Please fix.
Yes, I think so. Actually the CODEC driver was merged before PMIC ino
main line and was tested at that time. I will check with PMIC team if
they did test with CODEC.
I guess the fix should be in PMIC, right?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multiple DA9055 chips
2013-07-02 10:02 ` Ashish Chavan
@ 2013-07-02 10:31 ` Mark Brown
2013-07-02 11:07 ` Ashish Chavan
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2013-07-02 10:31 UTC (permalink / raw)
To: Ashish Chavan
Cc: David Dajun Chen, Ashish Jangam, alsa-devel, linux-kernel,
Samuel Ortiz, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
On Tue, Jul 02, 2013 at 03:32:37PM +0530, Ashish Chavan wrote:
> > OK, in that case the CODEC driver is just plain broken then. Did anyone
> > actually test this stuff? Please fix.
> Yes, I think so. Actually the CODEC driver was merged before PMIC ino
> main line and was tested at that time. I will check with PMIC team if
> they did test with CODEC.
> I guess the fix should be in PMIC, right?
Both drivers need to be changed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multiple DA9055 chips
2013-07-02 10:31 ` Mark Brown
@ 2013-07-02 11:07 ` Ashish Chavan
0 siblings, 0 replies; 6+ messages in thread
From: Ashish Chavan @ 2013-07-02 11:07 UTC (permalink / raw)
To: Mark Brown
Cc: David Dajun Chen, Ashish Jangam, alsa-devel, linux-kernel,
Samuel Ortiz, Lee Jones
On Tue, 2013-07-02 at 11:31 +0100, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 03:32:37PM +0530, Ashish Chavan wrote:
>
> > > OK, in that case the CODEC driver is just plain broken then. Did anyone
> > > actually test this stuff? Please fix.
>
> > Yes, I think so. Actually the CODEC driver was merged before PMIC ino
> > main line and was tested at that time. I will check with PMIC team if
> > they did test with CODEC.
>
> > I guess the fix should be in PMIC, right?
>
> Both drivers need to be changed.
OK. We will fix both of them.
Thanks for pointing this out.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-02 10:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-01 16:48 Multiple DA9055 chips Mark Brown
2013-07-02 9:31 ` Ashish Chavan
2013-07-02 9:31 ` Mark Brown
2013-07-02 10:02 ` Ashish Chavan
2013-07-02 10:31 ` Mark Brown
2013-07-02 11:07 ` Ashish Chavan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox