From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hyeoncheol Lee <cheol.lee@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH 09/12] tracing/uprobes: Fix a comment for uprobe registration syntax
Date: Wed, 3 Jul 2013 21:35:43 +0900 [thread overview]
Message-ID: <1372854946-17074-10-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1372854946-17074-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
The uprobe syntax requires an offset after a file path not a symbol.
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/trace/trace_uprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 8611b3289393..8c1cf7cfa181 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -196,7 +196,7 @@ end:
/*
* Argument syntax:
- * - Add uprobe: p|r[:[GRP/]EVENT] PATH:SYMBOL [FETCHARGS]
+ * - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS]
*
* - Remove uprobe: -:[GRP/]EVENT
*/
--
1.7.11.7
next prev parent reply other threads:[~2013-07-03 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 12:35 [PATCHSET 00/12] tracing/uprobes: Add support for more fetch methods Namhyung Kim
2013-07-03 12:35 ` [PATCH 01/12] tracing/kprobes: Move fetch functions to trace_kprobe.c Namhyung Kim
2013-07-03 12:35 ` [PATCH 02/12] tracing/kprobes: Add fetch{,_size} member into symbol and deref fetch method Namhyung Kim
2013-07-03 12:35 ` [PATCH 03/12] tracing/kprobes: Make stack and memory fetch functions static Namhyung Kim
2013-07-03 12:35 ` [PATCH 04/12] tracing/kprobes: Factor out struct trace_probe Namhyung Kim
2013-07-03 12:35 ` [PATCH 05/12] tracing/uprobes: Convert to " Namhyung Kim
2013-07-03 12:35 ` [PATCH 06/12] tracing/kprobes: Move common functions to trace_probe.c Namhyung Kim
2013-07-03 12:35 ` [PATCH 07/12] tracing/kprobes: Remove duplicate set_print_fmt() Namhyung Kim
2013-07-03 12:35 ` [PATCH 08/12] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-07-03 12:35 ` Namhyung Kim [this message]
2013-07-03 12:35 ` [PATCH 10/12] tracing/kprobes: Add priv argument to fetch functions Namhyung Kim
2013-07-03 12:35 ` [PATCH 11/12] tracing/uprobes: Add more " Namhyung Kim
2013-07-03 12:35 ` [PATCH 12/12] tracing/uprobes: Add support for full argument access methods Namhyung Kim
2013-07-03 14:22 ` [PATCHSET 00/12] tracing/uprobes: Add support for more fetch methods Steven Rostedt
2013-07-04 5:34 ` Namhyung Kim
2013-07-04 6:51 ` Masami Hiramatsu
2013-07-04 7:20 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372854946-17074-10-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=cheol.lee@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung.kim@lge.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox