From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable
Date: Wed, 10 Jul 2013 14:55:38 +0300 [thread overview]
Message-ID: <1373457340-16666-4-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1373457340-16666-1-git-send-email-andriy.shevchenko@linux.intel.com>
There is no need to have an additional variable in byt_gpio_reg().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-baytrail.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
index 06ffeee..14a143c 100644
--- a/drivers/pinctrl/pinctrl-baytrail.c
+++ b/drivers/pinctrl/pinctrl-baytrail.c
@@ -135,15 +135,13 @@ static void __iomem *byt_gpio_reg(struct gpio_chip *chip, unsigned offset,
{
struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip);
u32 reg_offset;
- void __iomem *ptr;
if (reg == BYT_INT_STAT_REG)
reg_offset = (offset / 32) * 4;
else
reg_offset = vg->range->pins[offset] * 16;
- ptr = (void __iomem *) (vg->reg_base + reg_offset + reg);
- return ptr;
+ return vg->reg_base + reg_offset + reg;
}
static int byt_gpio_request(struct gpio_chip *chip, unsigned offset)
--
1.8.3.2
next prev parent reply other threads:[~2013-07-10 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko
2013-07-10 11:55 ` [PATCH 1/5] pinctrl-baytrail: fix indentations Andy Shevchenko
2013-07-22 20:47 ` Linus Walleij
2013-07-10 11:55 ` [PATCH 2/5] pinctrl-baytrail: change lvl to level Andy Shevchenko
2013-07-10 13:42 ` [PATCH v1.5] " Andy Shevchenko
2013-07-22 20:48 ` Linus Walleij
2013-07-10 11:55 ` Andy Shevchenko [this message]
2013-07-22 20:49 ` [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable Linus Walleij
2013-07-10 11:55 ` [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro Andy Shevchenko
2013-07-22 20:50 ` Linus Walleij
2013-07-10 11:55 ` [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings Andy Shevchenko
2013-07-22 20:51 ` Linus Walleij
2013-07-15 10:24 ` [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko
2013-07-15 18:34 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373457340-16666-4-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox