From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH V5 09/12] perf: make events stream always parsable
Date: Thu, 11 Jul 2013 16:12:18 +0300 [thread overview]
Message-ID: <1373548341-24119-10-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1373548341-24119-1-git-send-email-adrian.hunter@intel.com>
The event stream is not always parsable because the format of a sample
is dependent on the sample_type of the selected event. When there
is more than one selected event and the sample_types are not the
same then parsing becomes problematic. A sample can be matched to its
selected event using the ID that is allocated when the event is opened.
Unfortunately, to get the ID from the sample means first parsing it.
This patch adds a new sample format bit PERF_SAMPLE_IDENTIFER that puts
the ID at a fixed position so that the ID can be retrieved without
parsing the sample. For sample events, that is the first position
immediately after the header. For non-sample events, that is the last
position.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
include/uapi/linux/perf_event.h | 3 ++-
kernel/events/core.c | 11 ++++++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 0b1df41..6bb217e 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -134,8 +134,9 @@ enum perf_event_sample_format {
PERF_SAMPLE_STACK_USER = 1U << 13,
PERF_SAMPLE_WEIGHT = 1U << 14,
PERF_SAMPLE_DATA_SRC = 1U << 15,
+ PERF_SAMPLE_IDENTIFIER = 1U << 16,
- PERF_SAMPLE_MAX = 1U << 16, /* non-ABI */
+ PERF_SAMPLE_MAX = 1U << 17, /* non-ABI */
};
/*
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 1833bc5..9908d3d 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -1203,6 +1203,9 @@ static void perf_event__id_header_size(struct perf_event *event)
if (sample_type & PERF_SAMPLE_TIME)
size += sizeof(data->time);
+ if (sample_type & PERF_SAMPLE_IDENTIFIER)
+ size += sizeof(data->id);
+
if (sample_type & PERF_SAMPLE_ID)
size += sizeof(data->id);
@@ -4229,7 +4232,7 @@ static void __perf_event_header__init_id(struct perf_event_header *header,
if (sample_type & PERF_SAMPLE_TIME)
data->time = perf_clock();
- if (sample_type & PERF_SAMPLE_ID)
+ if (sample_type & (PERF_SAMPLE_ID | PERF_SAMPLE_IDENTIFIER))
data->id = primary_event_id(event);
if (sample_type & PERF_SAMPLE_STREAM_ID)
@@ -4268,6 +4271,9 @@ static void __perf_event__output_id_sample(struct perf_output_handle *handle,
if (sample_type & PERF_SAMPLE_CPU)
perf_output_put(handle, data->cpu_entry);
+
+ if (sample_type & PERF_SAMPLE_IDENTIFIER)
+ perf_output_put(handle, data->id);
}
void perf_event__output_id_sample(struct perf_event *event,
@@ -4380,6 +4386,9 @@ void perf_output_sample(struct perf_output_handle *handle,
perf_output_put(handle, *header);
+ if (sample_type & PERF_SAMPLE_IDENTIFIER)
+ perf_output_put(handle, data->id);
+
if (sample_type & PERF_SAMPLE_IP)
perf_output_put(handle, data->ip);
--
1.7.11.7
next prev parent reply other threads:[~2013-07-11 13:09 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 13:12 [PATCH V5 00/12] perf tools: some fixes and tweaks Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 01/12] perf tools: add debug prints Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 02/12] perf tools: allow non-matching sample types Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 03/12] perf tools: add pid to struct thread Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 04/12] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 05/12] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 06/12] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 07/12] perf tools: remove references to struct ip_event Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 08/12] perf tools: move " Adrian Hunter
2013-07-11 13:12 ` Adrian Hunter [this message]
2013-07-11 15:43 ` [PATCH V5 09/12] perf: make events stream always parsable David Ahern
2013-07-11 17:16 ` David Ahern
2013-07-12 6:42 ` Adrian Hunter
2013-07-12 9:56 ` Peter Zijlstra
2013-07-12 12:56 ` Adrian Hunter
2013-07-12 14:55 ` Peter Zijlstra
2013-07-15 6:14 ` Adrian Hunter
2013-07-15 11:53 ` Stephane Eranian
2013-07-15 12:09 ` Adrian Hunter
2013-07-16 6:49 ` Adrian Hunter
2013-07-16 15:09 ` Peter Zijlstra
2013-07-17 4:10 ` Stephane Eranian
2013-07-17 12:44 ` Adrian Hunter
2013-07-24 3:55 ` [tip:perf/core] perf: Update perf_event_type documentation tip-bot for Peter Zijlstra
2013-07-24 17:54 ` Vince Weaver
2013-07-25 6:22 ` Adrian Hunter
2013-07-25 12:34 ` Vince Weaver
2013-07-25 16:27 ` Peter Zijlstra
2013-07-26 3:24 ` Vince Weaver
2013-07-26 8:55 ` Peter Zijlstra
2013-07-26 3:20 ` Vince Weaver
2013-07-26 8:57 ` Peter Zijlstra
2013-07-27 3:20 ` Vince Weaver
2013-07-25 10:04 ` Peter Zijlstra
2013-07-25 12:31 ` Vince Weaver
2013-07-25 12:39 ` David Ahern
2013-09-13 21:31 ` Vince Weaver
2013-09-13 21:42 ` Peter Zijlstra
2013-07-11 13:12 ` [PATCH V5 10/12] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 11/12] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 12/12] perf tools: add a sample parsing test Adrian Hunter
2013-07-16 12:48 ` Jiri Olsa
2013-07-17 11:02 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373548341-24119-10-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).