From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: [PATCH 4/5] perf tools: Remove event types pushing from record command
Date: Thu, 11 Jul 2013 17:28:32 +0200 [thread overview]
Message-ID: <1373556513-3000-5-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1373556513-3000-1-git-send-email-jolsa@redhat.com>
Removing event types data pushing from record command. It's
no longer needed, because this data is ignored.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
---
tools/perf/builtin-record.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index ecca62e..1f5243c 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -904,7 +904,6 @@ const struct option record_options[] = {
int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
{
int err = -ENOMEM;
- struct perf_evsel *pos;
struct perf_evlist *evsel_list;
struct perf_record *rec = &record;
char errbuf[BUFSIZ];
@@ -968,11 +967,6 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
if (perf_evlist__create_maps(evsel_list, &rec->opts.target) < 0)
usage_with_options(record_usage, record_options);
- list_for_each_entry(pos, &evsel_list->entries, node) {
- if (perf_header__push_event(pos->attr.config, perf_evsel__name(pos)))
- goto out_free_fd;
- }
-
if (rec->opts.user_interval != ULLONG_MAX)
rec->opts.default_interval = rec->opts.user_interval;
if (rec->opts.user_freq != UINT_MAX)
--
1.7.11.7
next prev parent reply other threads:[~2013-07-11 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 15:28 [PATCHv2 0/5] perf tools: Remove event types data Jiri Olsa
2013-07-11 15:28 ` [PATCH 1/5] perf tools: Add traceevent lib event-parse.h include to timechart Jiri Olsa
2013-07-19 7:52 ` [tip:perf/core] perf timechart: Use traceevent lib event-parse.h include tip-bot for Jiri Olsa
2013-07-11 15:28 ` [PATCH 2/5] perf tools: Remove event types framework only user Jiri Olsa
2013-07-19 7:53 ` [tip:perf/core] perf timechart: " tip-bot for Jiri Olsa
2013-07-11 15:28 ` [PATCH 3/5] perf tools: Remove event types from perf data file Jiri Olsa
2013-07-19 7:53 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-07-11 15:28 ` Jiri Olsa [this message]
2013-07-19 7:53 ` [tip:perf/core] perf record: Remove event types pushing tip-bot for Jiri Olsa
2013-07-11 15:28 ` [PATCH 5/5] perf tools: Remove event types framework completely Jiri Olsa
2013-07-19 7:53 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-07-12 8:53 ` [PATCHv2 0/5] perf tools: Remove event types data Namhyung Kim
2013-07-15 19:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373556513-3000-5-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox