From: David Ahern <dsahern@gmail.com>
To: acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Runzhen Wang <runzhen@linux.vnet.ibm.com>
Subject: [PATCH 11/11] perf kvm: debug for missing vmexit/vmentry event
Date: Thu, 11 Jul 2013 10:26:42 -0600 [thread overview]
Message-ID: <1373560002-14618-12-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1373560002-14618-1-git-send-email-dsahern@gmail.com>
Expected to have missing events for each vcpu when perf is
started. After that should not have missing events.
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Runzhen Wang <runzhen@linux.vnet.ibm.com>
---
tools/perf/builtin-kvm.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index c2fede6..76cfe59 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -568,11 +568,22 @@ static bool handle_kvm_event(struct perf_kvm_stat *kvm,
(kvm->trace_vcpu != vcpu_record->vcpu_id))
return true;
- if (kvm->events_ops->is_begin_event(evsel, sample, &key))
+ if (kvm->events_ops->is_begin_event(evsel, sample, &key)) {
+ if (vcpu_record->start_time) {
+ pr_debug("consecutive begin events (%s) for pid %d, vcpu %d\n",
+ evsel->name, sample->pid, vcpu_record->vcpu_id);
+ }
return handle_begin_event(kvm, vcpu_record, &key, sample->time);
+ }
+
- if (kvm->events_ops->is_end_event(evsel, sample, &key))
+ if (kvm->events_ops->is_end_event(evsel, sample, &key)) {
+ if (vcpu_record->start_time == 0) {
+ pr_debug("consecutive end events (%s) for pid %d, vcpu %d\n",
+ evsel->name, sample->pid, vcpu_record->vcpu_id);
+ }
return handle_end_event(kvm, vcpu_record, &key, sample);
+ }
return true;
}
--
1.7.10.1
prev parent reply other threads:[~2013-07-11 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 16:26 [PATCH 00/11] perf: kvm live mode David Ahern
2013-07-11 16:26 ` [PATCH 01/11] perf evlist: restore methods removed in earlier cleanup David Ahern
2013-07-11 16:26 ` [PATCH 02/11] perf evlist: move tracepoint processing code to evlist.c David Ahern
2013-07-11 16:26 ` [PATCH 03/11] perf evlist: add initialzation function for tracepoints David Ahern
2013-07-11 16:26 ` [PATCH 04/11] perf session: export a few functions for event processing David Ahern
2013-07-11 16:26 ` [PATCH 05/11] perf top: move CONSOLE_CLEAR to header file David Ahern
2013-07-11 16:26 ` [PATCH 06/11] perf kvm: split out tracepoints from record args David Ahern
2013-07-11 16:26 ` [PATCH 07/11] perf stats: add max and min stats David Ahern
2013-07-11 16:26 ` [PATCH 08/11] perf kvm: add live mode David Ahern
2013-07-11 16:26 ` [PATCH 09/11] perf kvm: add min and max stats to display David Ahern
2013-07-11 16:26 ` [PATCH 10/11] perf kvm: option to print events that exceed a threshold David Ahern
2013-07-11 16:26 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373560002-14618-12-git-send-email-dsahern@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox