From: Joe Perches <joe@perches.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] media: davinci: vpbe: Replace printk with dev_*
Date: Sat, 13 Jul 2013 06:07:23 -0700 [thread overview]
Message-ID: <1373720843.1906.4.camel@joe-AO722> (raw)
In-Reply-To: <1373705431-11500-6-git-send-email-prabhakar.csengg@gmail.com>
On Sat, 2013-07-13 at 14:20 +0530, Prabhakar Lad wrote:
> Use the dev_* message logging API instead of raw printk.
[]
> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
[]
> @@ -735,7 +735,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
>
> mutex_unlock(&vpbe_dev->lock);
>
> - printk(KERN_NOTICE "Setting default output to %s\n", def_output);
> + dev_info(dev, "Setting default output to %s\n", def_output);
You are changing logging levels too.
You should mention that in the changelog.
> @@ -743,7 +743,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
> return ret;
> }
>
> - printk(KERN_NOTICE "Setting default mode to %s\n", def_mode);
> + dev_info(dev, "Setting default mode to %s\n", def_mode);
> ret = vpbe_set_default_mode(vpbe_dev);
> if (ret) {
> v4l2_err(&vpbe_dev->v4l2_dev, "Failed to set default mode %s",
Maybe these should be v4l2_notice() which could
be added to include/media/v4l2-common.h
next prev parent reply other threads:[~2013-07-13 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 8:50 [PATCH 0/5] Davinci VPBE use devres and some cleanup Prabhakar Lad
2013-07-13 8:50 ` [PATCH 1/5] media: davinci: vpbe_venc: convert to devm_* api Prabhakar Lad
2013-07-13 8:50 ` [PATCH 2/5] media: davinci: vpbe_osd: " Prabhakar Lad
2013-07-13 8:50 ` [PATCH 3/5] media: davinci: vpbe_display: convert to devm* api Prabhakar Lad
2013-07-13 8:50 ` [PATCH 4/5] media: davinci: vpss: " Prabhakar Lad
2013-07-13 8:50 ` [PATCH 5/5] media: davinci: vpbe: Replace printk with dev_* Prabhakar Lad
2013-07-13 13:07 ` Joe Perches [this message]
2013-07-17 12:21 ` [PATCH 0/5] Davinci VPBE use devres and some cleanup Laurent Pinchart
2013-07-17 16:30 ` Prabhakar Lad
2013-07-23 11:17 ` Prabhakar Lad
2013-07-23 11:44 ` Abraham, Tobin
2013-07-23 11:50 ` Prabhakar Lad
2013-07-23 11:49 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373720843.1906.4.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).