From: Joe Perches <joe@perches.com>
To: Richard Henderson <rth@twiddle.net>
Cc: linux-kernel@vger.kernel.org, ink@jurassic.park.msu.ru,
mattst88@gmail.com, linux-alpha@vger.kernel.org
Subject: Re: [PATCH 3/7] alpha: Modernize lib/mpi/longlong.h
Date: Tue, 16 Jul 2013 10:19:19 -0700 [thread overview]
Message-ID: <1373995159.1949.8.camel@joe-AO722> (raw)
In-Reply-To: <1373994280-12047-4-git-send-email-rth@twiddle.net>
On Tue, 2013-07-16 at 10:04 -0700, Richard Henderson wrote:
> Remove the compile warning for __udiv_qrnnd not having a prototype.
> Use the __builtin_alpha_umulh introduced in gcc 4.0.
Isn't gcc 3.x still a supported compiler?
> diff --git a/lib/mpi/longlong.h b/lib/mpi/longlong.h
[]
> @@ -151,15 +151,12 @@ do { \
> #endif /* __a29k__ */
>
> #if defined(__alpha) && W_TYPE_SIZE == 64
> -#define umul_ppmm(ph, pl, m0, m1) \
> -do { \
> - UDItype __m0 = (m0), __m1 = (m1); \
> - __asm__ ("umulh %r1,%2,%0" \
> - : "=r" ((UDItype) ph) \
> - : "%rJ" (__m0), \
> - "rI" (__m1)); \
> - (pl) = __m0 * __m1; \
> - } while (0)
> +#define umul_ppmm(ph, pl, m0, m1) \
> +do { \
> + UDItype __m0 = (m0), __m1 = (m1); \
> + (ph) = __builtin_alpha_umulh(__m0, __m1); \
> + (pl) = __m0 * __m1; \
> +} while (0)
> #define UMUL_TIME 46
> #ifndef LONGLONG_STANDALONE
> #define udiv_qrnnd(q, r, n1, n0, d) \
> @@ -167,7 +164,7 @@ do { UDItype __r; \
> (q) = __udiv_qrnnd(&__r, (n1), (n0), (d)); \
> (r) = __r; \
> } while (0)
> -extern UDItype __udiv_qrnnd();
> +extern UDItype __udiv_qrnnd(UDItype *, UDItype, UDItype, UDItype);
> #define UDIV_TIME 220
> #endif /* LONGLONG_STANDALONE */
> #endif /* __alpha */
next prev parent reply other threads:[~2013-07-16 17:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 17:04 [PATCH 0/7] Minor Alpha updates for 3.11 Richard Henderson
2013-07-16 17:04 ` [PATCH 1/7] alpha: Add kcmp and finit_module syscalls Richard Henderson
2013-07-16 17:04 ` [PATCH 2/7] alpha: Eliminate compiler warning from memset macro Richard Henderson
2013-07-17 19:54 ` Matt Turner
2013-07-16 17:04 ` [PATCH 3/7] alpha: Modernize lib/mpi/longlong.h Richard Henderson
2013-07-16 17:19 ` Joe Perches [this message]
2013-07-16 18:55 ` Richard Henderson
2013-07-16 17:04 ` [PATCH 4/7] alpha: Improve atomic_add_unless Richard Henderson
2013-07-16 17:04 ` [PATCH 5/7] alpha: Implement atomic64_dec_if_positive Richard Henderson
2013-07-16 17:04 ` [PATCH 6/7] alpha: Generate dwarf2 unwind info for various kernel entry points Richard Henderson
2013-07-16 17:04 ` [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq Richard Henderson
2013-07-16 23:35 ` [PATCH 0/7] Minor Alpha updates for 3.11 Rob Landley
2013-07-17 0:03 ` Michael Cree
2013-07-23 2:31 ` Rob Landley
2013-07-23 3:25 ` Michael Cree
2013-07-23 15:20 ` Richard Henderson
2013-07-24 10:25 ` Michael Cree
2013-07-24 17:55 ` Richard Henderson
2013-07-17 4:29 ` Matt Turner
2013-07-17 13:02 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373995159.1949.8.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox