From: Jean Delvare <jdelvare@suse.de>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH 3/6] kconfig/[mn]conf: shorten title in search-box
Date: Wed, 17 Jul 2013 11:55:12 +0200 [thread overview]
Message-ID: <1374054912.4495.0.camel@chaos.site> (raw)
In-Reply-To: <f6eb6e46f766f4e2eb64d2d467ef7efff084c47c.1374006854.git.yann.morin.1998@free.fr>
Le Tuesday 16 July 2013 à 22:39 +0200, Yann E. MORIN a écrit :
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> No need to repeat the 'CONFIG_' string in the title,
> once is explicit enough.
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Jean Delvare <jdelvare@suse.de>
> ---
> scripts/kconfig/mconf.c | 4 ++--
> scripts/kconfig/nconf.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 18d3dc9..b20e851 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -401,8 +401,8 @@ static void search_conf(void)
> struct subtitle_part stpart;
>
> title = str_new();
> - str_printf( &title, _("Enter %s (sub)string or regexp to search for "
> - "(with or without \"%s\")"), CONFIG_, CONFIG_);
> + str_printf( &title, _("Enter (sub)string or regexp to search for "
> + "(with or without \"%s\")"), CONFIG_);
>
> again:
> dialog_clear();
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 7975d8d..4fbecd2 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -695,8 +695,8 @@ static void search_conf(void)
> int dres;
>
> title = str_new();
> - str_printf( &title, _("Enter %s (sub)string or regexp to search for "
> - "(with or without \"%s\")"), CONFIG_, CONFIG_);
> + str_printf( &title, _("Enter (sub)string or regexp to search for "
> + "(with or without \"%s\")"), CONFIG_);
>
> again:
> dres = dialog_inputbox(main_window,
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
Suse L3
next prev parent reply other threads:[~2013-07-17 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 20:39 [pull request] Pull request for branch yem-kconfig-rc-fixes Yann E. MORIN
2013-07-16 20:39 ` [PATCH 1/6] Documentation/kconfig: more concise and straightforward search explanation Yann E. MORIN
2013-07-16 20:39 ` [PATCH 2/6] kconfig: avoid multiple calls to strlen Yann E. MORIN
2013-07-16 20:39 ` [PATCH 3/6] kconfig/[mn]conf: shorten title in search-box Yann E. MORIN
2013-07-17 9:55 ` Jean Delvare [this message]
2013-07-16 20:40 ` [PATCH 4/6] kconfig: minor style fixes in symbol-search code Yann E. MORIN
2013-07-16 20:40 ` [PATCH 5/6] kconfig: don't allocate n+1 elements in temporary array Yann E. MORIN
2013-07-16 20:40 ` [PATCH 6/6] kconfig: simplify symbol-search code Yann E. MORIN
2013-07-17 9:59 ` [pull request] Pull request for branch yem-kconfig-rc-fixes Jean Delvare
2013-07-23 13:37 ` Michal Marek
2013-07-23 13:54 ` Yann E. MORIN
2013-07-23 14:36 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374054912.4495.0.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).