From: enselic@gmail.com
To: matthew.garrett@nebula.com, bleung@chromium.org, olof@lixom.net
Cc: miletus@chromium.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Martin Nordholts <enselic@gmail.com>
Subject: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race
Date: Thu, 18 Jul 2013 17:58:10 +0200 [thread overview]
Message-ID: <1374163091-4750-1-git-send-email-enselic@gmail.com> (raw)
From: Martin Nordholts <enselic@gmail.com>
Hello,
I have looked into solving the "touchpad/touchscreen not working on
boot"-problem on Chromebook Pixel, see for example Brock Tice's last
comment on https://plus.google.com/+LinusTorvalds/posts/1iFsBWBqoYY
I have seen Olof's attempt at a fix:
[PATCH] Platform: x86: chromeos_laptop: defer probing if no i2c busses found
https://lkml.org/lkml/2013/4/18/556
At first, I tried Olofs suggestion at the end of the thread, namely to
do bus_register_notifier() on i2c_bus_type, but it is a bit awkward:
How do you know that the i2c_adapter you are notified about is ready
to be interacted with? While investigating this, I noticed that the
i2c_driver has a .detect() mechanism, which is exactly what we need: A
callback when a newly added i2c_adapter is initialized and ready to be
used.
Since all chromeos_laptop does is to instantiate i2c devices, I
figured it would be nice to simply convert chromeos_laptop into a
i2c_driver. The result is the patch in the next mail (based on
v3.11-rc1).
I have gone through the SubmitChecklist and done everything that
applied. I have however only tested this patch on the Chromebook
Pixel, as that is what I have. I will need help with verifying the
patch on other Chromebooks.
But first, what do you think about my patch?
/ Martin
Martin Nordholts (1):
Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915
race
drivers/platform/x86/chromeos_laptop.c | 426 +++++++++++++++-----------------
1 file changed, 194 insertions(+), 232 deletions(-)
--
1.7.10.4
next reply other threads:[~2013-07-18 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 15:58 enselic [this message]
2013-07-18 15:58 ` [PATCH 1/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race enselic
2013-08-05 3:52 ` [PATCH 0/1] " Benson Leung
2013-08-05 5:32 ` Martin Nordholts
2013-08-07 21:55 ` Benson Leung
2013-08-11 19:54 ` Martin Nordholts
2013-08-11 22:44 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374163091-4750-1-git-send-email-enselic@gmail.com \
--to=enselic@gmail.com \
--cc=bleung@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=miletus@chromium.org \
--cc=olof@lixom.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox