* [PATCH] hw_random: mxc-rnga: Check the return value from clk_prepare_enable()
@ 2013-07-21 17:41 Fabio Estevam
2013-08-01 1:47 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-07-21 17:41 UTC (permalink / raw)
To: herbert; +Cc: s.hauer, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
clk_prepare_enable() may fail, so let's check its return value and propagate it
in the case of error.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/char/hw_random/mxc-rnga.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/mxc-rnga.c b/drivers/char/hw_random/mxc-rnga.c
index 19a12ac..6a86b6f 100644
--- a/drivers/char/hw_random/mxc-rnga.c
+++ b/drivers/char/hw_random/mxc-rnga.c
@@ -164,7 +164,9 @@ static int __init mxc_rnga_probe(struct platform_device *pdev)
goto out;
}
- clk_prepare_enable(mxc_rng->clk);
+ err = clk_prepare_enable(mxc_rng->clk);
+ if (err)
+ goto out;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
mxc_rng->mem = devm_ioremap_resource(&pdev->dev, res);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw_random: mxc-rnga: Check the return value from clk_prepare_enable()
2013-07-21 17:41 [PATCH] hw_random: mxc-rnga: Check the return value from clk_prepare_enable() Fabio Estevam
@ 2013-08-01 1:47 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2013-08-01 1:47 UTC (permalink / raw)
To: Fabio Estevam; +Cc: s.hauer, linux-kernel, Fabio Estevam
On Sun, Jul 21, 2013 at 02:41:38PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> clk_prepare_enable() may fail, so let's check its return value and propagate it
> in the case of error.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-01 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-21 17:41 [PATCH] hw_random: mxc-rnga: Check the return value from clk_prepare_enable() Fabio Estevam
2013-08-01 1:47 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox