linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	David Ahern <dsahern@gmail.com>, Borislav Petkov <bp@alien8.de>
Subject: [PATCH 1/5] perf tests: Run ctags/cscope make tests only with needed binaries
Date: Mon, 22 Jul 2013 14:43:30 +0200	[thread overview]
Message-ID: <1374497014-2817-2-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1374497014-2817-1-git-send-email-jolsa@redhat.com>

Running tags and cscope make tests only if the 'ctags'
and 'cscope' binaries are installed, so we don't have
false alarm test failures.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>
---
 tools/perf/tests/make | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/make b/tools/perf/tests/make
index c441a28..d1efef9 100644
--- a/tools/perf/tests/make
+++ b/tools/perf/tests/make
@@ -1,6 +1,8 @@
 PERF := .
 MK   := Makefile
 
+has = $(shell which $1 2>/dev/null)
+
 # standard single make variable specified
 make_clean_all      := clean all
 make_python_perf_so := python/perf.so
@@ -50,14 +52,19 @@ run += make_no_backtrace
 run += make_no_libnuma
 run += make_no_libaudit
 run += make_no_libbionic
-run += make_tags
-run += make_cscope
 run += make_help
 run += make_doc
 run += make_perf_o
 run += make_util_map_o
 run += make_minimal
 
+ifneq ($(call has,ctags),)
+run += make_tags
+endif
+ifneq ($(call has,cscope),)
+run += make_cscope
+endif
+
 # $(run_O) contains same portion of $(run) tests with '_O' attached
 # to distinguish O=... tests
 run_O := $(addsuffix _O,$(run))
-- 
1.7.11.7


  reply	other threads:[~2013-07-22 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 12:43 [PATCH 0/5] perf tests: Add install tests to tests/make Jiri Olsa
2013-07-22 12:43 ` Jiri Olsa [this message]
2013-07-23  7:47   ` [tip:perf/core] perf tests: Run ctags/ cscope make tests only with needed binaries tip-bot for Jiri Olsa
2013-07-22 12:43 ` [PATCH 2/5] perf tests: Rename TMP to TMP_O tests/make variable Jiri Olsa
2013-07-23  7:47   ` [tip:perf/core] perf tests: Rename TMP to TMP_O tests/ make variable tip-bot for Jiri Olsa
2013-07-22 12:43 ` [PATCH 3/5] perf tests: Add DESTDIR=TMP_DEST tests/make variable Jiri Olsa
2013-07-23  7:47   ` [tip:perf/core] perf tests: Add DESTDIR=TMP_DEST tests/ make variable tip-bot for Jiri Olsa
2013-07-22 12:43 ` [PATCH 4/5] perf tests: Add 'make install/install-bin' tests into tests/make Jiri Olsa
2013-07-23  7:48   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-07-22 12:43 ` [PATCH 5/5] perf tests: Add broken install-* " Jiri Olsa
2013-07-23  7:48   ` [tip:perf/core] perf tests: Add broken install-* tests into tests /make tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374497014-2817-2-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=bp@alien8.de \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).