From: Lilis Iskandar <veeableful@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: Qos: Fix some coding style issues
Date: Wed, 24 Jul 2013 02:25:25 +0800 [thread overview]
Message-ID: <1374603925.20981.8.camel@desktop> (raw)
In-Reply-To: <1374597753.3387.4.camel@joe-AO722>
On Tue, 2013-07-23 at 09:42 -0700, Joe Perches wrote:
> On Tue, 2013-07-23 at 19:51 +0800, Lilis Iskandar wrote:
> > Fixed spacing/tabs issues that were found using checkpatch.
>
> Hi Lilis.
>
> It'd be better to change the email subject to
> "[PATCH v2] etc..." to show that's it's a new
> version of the patch.
>
> It's also useful to add a note or two like
> "git diff -w shows no differences" and
> "no differences in objects" to make review
> and acceptance a bit easier.
>
> Good luck with continued cleanups of bcm.
> There's a lot to clean in those files.
Thanks for the advice! I'll keep that in mind for the following patches.
prev parent reply other threads:[~2013-07-23 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 9:20 [PATCH] Staging: bcm: Qos: Fix some coding style issues Lilis Iskandar
2013-07-23 9:54 ` Dan Carpenter
2013-07-23 10:10 ` Lilis Iskandar
2013-07-23 10:18 ` Dan Carpenter
2013-07-23 11:51 ` Lilis Iskandar
2013-07-23 15:11 ` Dan Carpenter
2013-07-23 16:42 ` Joe Perches
2013-07-23 18:25 ` Lilis Iskandar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374603925.20981.8.camel@desktop \
--to=veeableful@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).