* [PATCH] gpio_msm: Fix build error due to missing err.h
@ 2013-07-24 20:20 Stephen Boyd
2013-07-25 3:41 ` Tushar Behera
2013-07-29 15:37 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2013-07-24 20:20 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel, linux-gpio, Tushar Behera
drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
drivers/gpio/gpio-msm-v1.c:656:2:
error: implicit declaration of function 'IS_ERR'
[-Werror=implicit-function-declaration]
drivers/gpio/gpio-msm-v1.c:657:3:
error: implicit declaration of function 'PTR_ERR'
[-Werror=implicit-function-declaration]
This driver failed to compile after commit 68515bb
(gpio_msm: Convert to use devm_ioremap_resource,
2013-06-10).
Cc: Tushar Behera <tushar.behera@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/gpio/gpio-msm-v1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
index e3ceaac..73b7396 100644
--- a/drivers/gpio/gpio-msm-v1.c
+++ b/drivers/gpio/gpio-msm-v1.c
@@ -21,6 +21,7 @@
#include <linux/module.h>
#include <linux/device.h>
#include <linux/platform_device.h>
+#include <linux/err.h>
#include <mach/msm_gpiomux.h>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio_msm: Fix build error due to missing err.h
2013-07-24 20:20 [PATCH] gpio_msm: Fix build error due to missing err.h Stephen Boyd
@ 2013-07-25 3:41 ` Tushar Behera
2013-07-29 15:37 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tushar Behera @ 2013-07-25 3:41 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Linus Walleij, linux-kernel, linux-gpio
On 07/25/2013 01:50 AM, Stephen Boyd wrote:
> drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
> drivers/gpio/gpio-msm-v1.c:656:2:
> error: implicit declaration of function 'IS_ERR'
> [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-msm-v1.c:657:3:
> error: implicit declaration of function 'PTR_ERR'
> [-Werror=implicit-function-declaration]
>
> This driver failed to compile after commit 68515bb
> (gpio_msm: Convert to use devm_ioremap_resource,
> 2013-06-10).
>
> Cc: Tushar Behera <tushar.behera@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Sorry for this. I must have messed up while testing this patchset.
Acked-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/gpio/gpio-msm-v1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
> index e3ceaac..73b7396 100644
> --- a/drivers/gpio/gpio-msm-v1.c
> +++ b/drivers/gpio/gpio-msm-v1.c
> @@ -21,6 +21,7 @@
> #include <linux/module.h>
> #include <linux/device.h>
> #include <linux/platform_device.h>
> +#include <linux/err.h>
>
> #include <mach/msm_gpiomux.h>
>
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio_msm: Fix build error due to missing err.h
2013-07-24 20:20 [PATCH] gpio_msm: Fix build error due to missing err.h Stephen Boyd
2013-07-25 3:41 ` Tushar Behera
@ 2013-07-29 15:37 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-07-29 15:37 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Tushar Behera
On Wed, Jul 24, 2013 at 10:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
> drivers/gpio/gpio-msm-v1.c:656:2:
> error: implicit declaration of function 'IS_ERR'
> [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-msm-v1.c:657:3:
> error: implicit declaration of function 'PTR_ERR'
> [-Werror=implicit-function-declaration]
>
> This driver failed to compile after commit 68515bb
> (gpio_msm: Convert to use devm_ioremap_resource,
> 2013-06-10).
>
> Cc: Tushar Behera <tushar.behera@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks, patch applied and queued for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-29 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-24 20:20 [PATCH] gpio_msm: Fix build error due to missing err.h Stephen Boyd
2013-07-25 3:41 ` Tushar Behera
2013-07-29 15:37 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox