public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Robin Gong <b38343@freescale.com>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: regulator: pfuze100: A few small questions
Date: Mon, 29 Jul 2013 15:26:14 +0800	[thread overview]
Message-ID: <1375082774.7272.1.camel@phoenix> (raw)

Hi Robin,
2 questions about the code in pfuze100 driver:

1)
Both PFUZE100_REVID and PFUZE100_FABID are defined as 0x3.
So I'm wondering if it's a typo in one of the register address?
If they are actually the same register, we don't need to read the same
register twice in pfuze_identify().

2)
What is the the purpose of stby_reg and stby_mask?
Seems current code does not use it?



             reply	other threads:[~2013-07-29  7:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29  7:26 Axel Lin [this message]
2013-07-29  8:20 ` regulator: pfuze100: A few small questions Axel Lin
2013-07-29  9:28   ` Robin Gong
2013-07-29 15:44     ` Axel Lin
2013-07-30  2:26       ` Robin Gong
2013-07-30  2:26         ` Axel Lin
2013-07-30  2:36           ` Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375082774.7272.1.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=b38343@freescale.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox