linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Subject: Re: [PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulators support.
Date: Mon, 29 Jul 2013 10:28:30 +0200	[thread overview]
Message-ID: <1375086510.4223.2.camel@pizza.hi.pengutronix.de> (raw)
In-Reply-To: <20130728125111.GW9858@sirena.org.uk>

Hi Mark,

Am Sonntag, den 28.07.2013, 13:51 +0100 schrieb Mark Brown:
> On Thu, Jul 25, 2013 at 07:39:03PM +0200, Philipp Zabel wrote:
> 
> >  - 1x power switch to switch on/off 32 KHz oscilator output (32K_OUT).
> 
> The driver looks good except this should be implemented using the clock
> API not the regulator API - some drivers did this while we didn't have a
> clock API but we do now and in any case the clock shouldn't appear as a
> regulator in the DT bindings.

Thanks, I'll change this to use the clock API then.

regards
Philipp


      reply	other threads:[~2013-07-29  8:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 17:39 [PATCH v2 0/2] Add Dialog DA9063 core and regulator drivers Philipp Zabel
2013-07-25 17:39 ` [PATCH v2 1/2] mfd: Add Dialog DA9063 core driver Philipp Zabel
2013-07-28 12:55   ` Mark Brown
2013-07-25 17:39 ` [PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulators support Philipp Zabel
2013-07-28 12:51   ` Mark Brown
2013-07-29  8:28     ` Philipp Zabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375086510.4223.2.camel@pizza.hi.pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=broonie@kernel.org \
    --cc=krystian.garbaciak@diasemi.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).