From: Abbas Raza <abbas_raza@mentor.com>
To: linux-kernel@vger.kernel.org
Cc: Abbas Raza <Abbas_Raza@mentor.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: [PATCH] sched: don't wait in kthread_bind for presmp initcalls
Date: Mon, 29 Jul 2013 22:19:08 +0500 [thread overview]
Message-ID: <1375118348-25253-1-git-send-email-abbas_raza@mentor.com> (raw)
From: Abbas Raza <Abbas_Raza@mentor.com>
wait_task_inactive shouldn't be called in kthread_bind for presmp
initcalls the same way it is done in !SMP case.
more info here:
http://permalink.gmane.org/gmane.linux.kernel.embedded/4046
This patch improves boot time for pre-smp initcalls as given below
initcall spawn_ksoftirqd+0x0/0x54 returned 0 after 0 usecs
initcall init_workqueues+0x0/0x358 returned 0 after 0 usecs
initcall cpu_stop_init+0x0/0xcc returned 0 after 0 usecs
boot time without this patch:
initcall spawn_ksoftirqd+0x0/0x54 returned 0 after 9765 usecs
initcall init_workqueues+0x0/0x358 returned 0 after 9765 usecs
initcall cpu_stop_init+0x0/0xcc returned 0 after 19531 usecs
Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
---
kernel/kthread.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index b579af5..80f19b5 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -221,10 +221,15 @@ EXPORT_SYMBOL(kthread_create_on_node);
*/
void kthread_bind(struct task_struct *p, unsigned int cpu)
{
- /* Must have done schedule() in kthread() before we set_task_cpu */
- if (!wait_task_inactive(p, TASK_UNINTERRUPTIBLE)) {
- WARN_ON(1);
- return;
+ if (!((num_online_cpus() == 1) && !cpu)) {
+ /*
+ * Must have done schedule() in kthread() before
+ * we set_task_cpu
+ */
+ if (!wait_task_inactive(p, TASK_UNINTERRUPTIBLE)) {
+ WARN_ON(1);
+ return;
+ }
}
/* It's safe because the task is inactive. */
--
1.8.3.2
next reply other threads:[~2013-07-29 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 17:19 Abbas Raza [this message]
2013-07-30 3:27 ` [PATCH] sched: don't wait in kthread_bind for presmp initcalls Xie XiuQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375118348-25253-1-git-send-email-abbas_raza@mentor.com \
--to=abbas_raza@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox