Re: [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach'

Arne Jansen
2013-08-08T19:09:08Z

On 08/08/13 19:46, Zach Brown wrote:
>>> even though the function is currently unused, I'm hesitating to remove it
>>> as it's part of the reada-API and might be handy for anyone going to use
>>> the API in the future.
>>
>> I agree. As replied here,
>> http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg24047.html
>> please keep the function.
>
> If we're keeping score, put me down for being in favour of removing dead
> untested code. git ressurection is easy.

It's not really untested, it has been in use some time ago. But of
course there's a chance that some changes broke it.
Yes, git ressurection is easy. To inform potential users, you might
just leave a comment like this:

/*
* There has been a function once to detach from a running reada.
* If you need such functionality, just revert the commit that
* added this comment.
*/

-Arne

>
> - z
>