public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: acme@ghostprotocols.net, linux-kernel@vger.kernel.org, mingo@kernel.org
Cc: David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>
Subject: [PATCH 18/19] perf sched timehist: Print all events in verbose mode
Date: Wed,  7 Aug 2013 22:51:00 -0400	[thread overview]
Message-ID: <1375930261-77273-19-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1375930261-77273-1-git-send-email-dsahern@gmail.com>

Useful for debugging and correlating extra events in a file with
the scheduling events collected.

Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
---
 tools/perf/builtin-sched.c |   57 ++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 53 insertions(+), 4 deletions(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index f5e98f1..1be9081 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1897,6 +1897,50 @@ static struct thread *timehist_get_thread(struct perf_evsel *evsel,
 	return thread;
 }
 
+static void timehist_print_sched_event(struct perf_tool *tool,
+			       struct perf_evsel *evsel,
+			       struct perf_sample *sample,
+			       struct machine *machine)
+{
+	struct perf_sched *sched = container_of(tool, struct perf_sched, tool);
+	struct thread *thread;
+	struct thread_runtime *tr;
+	const char *evname;
+	char tstr[64];
+
+	thread = machine__findnew_thread(machine, sample->tid);
+	if (thread == NULL)
+		return;
+
+	tr = thread__priv(thread);
+	if (tr == NULL) {
+		tr = thread__init_runtime(thread, sample->pid);
+		if (tr == NULL)
+			return;
+	}
+
+	printf("%15s ", timehist_time_str(tstr, sizeof(tstr), sample->time));
+	printf("[%02d] ", sample->cpu);
+	if (sched->show_cpu_visual && sched->max_cpu)
+		printf("%*s  ", sched->max_cpu, "");
+
+	printf("%-*s ", comm_width, tr->commstr);
+
+	/* dt spacer */
+	printf(" %9s %9s ", "", "");
+
+	evname = perf_evsel__name(evsel);
+	printf("%s ", evname ? evname : "[unknown]");
+	if (evsel->attr.type == PERF_TYPE_TRACEPOINT) {
+		event_format__print(evsel->tp_format, sample->cpu,
+				    sample->raw_data, sample->raw_size);
+	}
+
+	printf("\n");
+
+	return;
+}
+
 static int timehist_sched_change_event(struct perf_tool *tool,
 				       struct perf_evsel *evsel,
 				       struct perf_sample *sample,
@@ -2079,12 +2123,14 @@ static void timehist_print_summary(struct perf_session *session)
 	printf_nsecs(total_run_time, 2);
 	printf("\n");
 }
+
 static int perf_timehist__process_sample(struct perf_tool *tool,
-					 union perf_event *event,
-					 struct perf_sample *sample,
-					 struct perf_evsel *evsel,
-					 struct machine *machine)
+						 union perf_event *event,
+						 struct perf_sample *sample,
+						 struct perf_evsel *evsel,
+						 struct machine *machine)
 {
+	struct perf_sched *sched = container_of(tool, struct perf_sched, tool);
 	int err = 0;
 
 	evsel->hists.stats.total_period += sample->period;
@@ -2094,6 +2140,9 @@ static int perf_timehist__process_sample(struct perf_tool *tool,
 		tracepoint_handler f = evsel->handler.func;
 		evsel->handler.data = event;
 
+		if (sched->show_events && verbose)
+			timehist_print_sched_event(tool, evsel, sample, machine);
+
 		if (f)
 			err = f(tool, evsel, sample, machine);
 	}
-- 
1.7.10.1


  parent reply	other threads:[~2013-08-08  2:52 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  2:50 [PATCH 00/19] perf sched: Add timehist subcommand David Ahern
2013-08-08  2:50 ` [PATCH 01/19] perf: sample after exit loses thread correlation - v3 David Ahern
2013-08-08 14:53   ` Arnaldo Carvalho de Melo
2013-08-08 20:42     ` David Ahern
2013-08-08 21:23       ` Arnaldo Carvalho de Melo
2013-08-08  2:50 ` [PATCH 02/19] perf sched: Simplify arguments to read_events David Ahern
2013-08-08 14:54   ` Arnaldo Carvalho de Melo
2013-08-15  7:55   ` [tip:perf/core] " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 03/19] perf sched: Remove thread lookup in sample handler David Ahern
2013-08-08 14:56   ` Arnaldo Carvalho de Melo
2013-08-15  7:55   ` [tip:perf/core] " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 04/19] perf sched: Remove sched_process_exit tracepoint David Ahern
2013-08-08 14:57   ` Arnaldo Carvalho de Melo
2013-08-15  7:55   ` [tip:perf/core] " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 05/19] perf sched: Remove sched_process_fork tracepoint David Ahern
2013-08-08 15:00   ` Arnaldo Carvalho de Melo
2013-08-15  7:55   ` [tip:perf/core] " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 06/19] perf symbol: Add optimization for idle kernel symbols David Ahern
2013-08-08  2:50 ` [PATCH 07/19] perf top: Use new idle_sym check David Ahern
2013-08-08 15:06   ` Arnaldo Carvalho de Melo
2013-08-09  2:49     ` David Ahern
2013-08-09 13:53       ` Arnaldo Carvalho de Melo
2013-08-08  2:50 ` [PATCH 08/19] perf symbol: Save vmlinux or kallsyms path loaded David Ahern
2013-08-08 15:08   ` Arnaldo Carvalho de Melo
2013-08-09  2:51     ` David Ahern
2013-08-08  2:50 ` [PATCH 09/19] perf tool: Simplify options to perf_evsel__print_ip David Ahern
2013-08-08 15:14   ` Arnaldo Carvalho de Melo
2013-08-15  7:55   ` [tip:perf/core] " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 10/19] perf tool: Add option to print stack trace on single line David Ahern
2013-08-15  7:55   ` [tip:perf/core] perf evsel: " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 11/19] perf tool: Add option to limit stack depth in callchain dumps David Ahern
2013-08-15  7:56   ` [tip:perf/core] perf evsel: " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 12/19] perf tool: Add support for exclude symbol list to symbol_conf David Ahern
2013-08-08  2:50 ` [PATCH 13/19] perf tool: Skip symbols in exclude list while printing callchain David Ahern
2013-08-08  2:50 ` [PATCH 14/19] perf sched: pass event to evsel handlers using data element David Ahern
2013-08-08  2:50 ` [PATCH 15/19] perf sched: Add timehist command David Ahern
2013-08-08  2:50 ` [PATCH 16/19] perf tool: Change perf_session__has_traces to actually check for tracepoints David Ahern
2013-08-08 15:16   ` Arnaldo Carvalho de Melo
2013-08-15  7:56   ` [tip:perf/core] perf session: " tip-bot for David Ahern
2013-08-08  2:50 ` [PATCH 17/19] perf sched timehist: Add support for context-switch event David Ahern
2013-08-08  2:51 ` David Ahern [this message]
2013-08-08  2:51 ` [PATCH 19/19] perf sched timehist: Add pid/tid option David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375930261-77273-19-git-send-email-dsahern@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox