From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, mingo@kernel.org, torvalds@linux-foundation.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 12/13] x86: move __copy_*_nocache might fault check out of line
Date: Fri, 9 Aug 2013 16:04:19 -0700 [thread overview]
Message-ID: <1376089460-5459-13-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1376089460-5459-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Can as well do the normal conditional resched check out of line.
This saves one function call.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/include/asm/uaccess_64.h | 6 ++++--
arch/x86/lib/copy_user_nocache_64.S | 7 +++++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/uaccess_64.h b/arch/x86/include/asm/uaccess_64.h
index b327057..831f4a3 100644
--- a/arch/x86/include/asm/uaccess_64.h
+++ b/arch/x86/include/asm/uaccess_64.h
@@ -243,12 +243,14 @@ __copy_to_user_inatomic(void __user *dst, const void *src, unsigned size)
extern long __copy_user_nocache(void *dst, const void __user *src,
unsigned size, int zerorest);
+extern long __copy_user_nocache_might_fault(void *dst, const void __user *src,
+ unsigned size, int zerorest);
static inline int
__copy_from_user_nocache(void *dst, const void __user *src, unsigned size)
{
- might_fault();
- return __copy_user_nocache(dst, src, size, 1);
+ might_fault_debug_only();
+ return __copy_user_nocache_might_fault(dst, src, size, 1);
}
static inline int
diff --git a/arch/x86/lib/copy_user_nocache_64.S b/arch/x86/lib/copy_user_nocache_64.S
index 6a4f43c..8e6b0bd 100644
--- a/arch/x86/lib/copy_user_nocache_64.S
+++ b/arch/x86/lib/copy_user_nocache_64.S
@@ -16,6 +16,7 @@
#include <asm/thread_info.h>
#include <asm/asm.h>
#include <asm/smap.h>
+#include "user-common.h"
.macro ALIGN_DESTINATION
#ifdef FIX_ALIGNMENT
@@ -43,6 +44,12 @@
#endif
.endm
+ENTRY(__copy_user_nocache_might_fault)
+ CFI_STARTPROC
+ GET_THREAD_AND_SCHEDULE %rax
+ CFI_ENDPROC
+ /* fall through */
+
/*
* copy_user_nocache - Uncached memory copy with exception handling
* This will force destination/source out of cache for more performance.
--
1.8.3.1
next prev parent reply other threads:[~2013-08-09 23:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 23:04 Re-tune x86 uaccess code for PREEMPT_VOLUNTARY Andi Kleen
2013-08-09 23:04 ` [PATCH 01/13] x86: Add 1/2/4/8 byte optimization to 64bit __copy_{from,to}_user_inatomic Andi Kleen
2013-08-09 23:04 ` [PATCH 02/13] x86: Include linux/sched.h in asm/uaccess.h Andi Kleen
2013-08-09 23:04 ` [PATCH 03/13] tree-sweep: Include linux/sched.h for might_sleep users Andi Kleen
2013-08-09 23:04 ` [PATCH 04/13] Move might_sleep and friends from kernel.h to sched.h Andi Kleen
2013-08-09 23:04 ` [PATCH 05/13] sched: mark should_resched() __always_inline Andi Kleen
2013-08-09 23:04 ` [PATCH 06/13] x86: Add 32bit versions of SAVE_ALL/RESTORE_ALL to calling.h Andi Kleen
2013-08-09 23:04 ` [PATCH 07/13] Add might_fault_debug_only() Andi Kleen
2013-08-14 18:24 ` Michael S. Tsirkin
2013-08-09 23:04 ` [PATCH 08/13] x86: Move cond_resched into the out of line put_user code Andi Kleen
2013-08-09 23:04 ` [PATCH 09/13] x86: Move cond_resched into the out of line get_user code Andi Kleen
2013-08-09 23:04 ` [PATCH 10/13] x86: Move cond resched for copy_{from,to}_user into low level code 64bit Andi Kleen
2013-08-10 15:42 ` Linus Torvalds
2013-08-10 16:10 ` Andi Kleen
2013-08-10 16:27 ` Linus Torvalds
2013-08-10 18:23 ` Borislav Petkov
2013-08-10 19:05 ` Jörn Engel
2013-08-20 21:03 ` KOSAKI Motohiro
2013-08-15 5:04 ` Michael S. Tsirkin
2013-08-09 23:04 ` [PATCH 11/13] sched: Inline the need_resched test into the caller for _cond_resched Andi Kleen
2013-08-09 23:04 ` Andi Kleen [this message]
2013-08-09 23:04 ` [PATCH 13/13] x86: drop cond rescheds from __copy_{from,to}_user Andi Kleen
2013-08-10 4:42 ` Re-tune x86 uaccess code for PREEMPT_VOLUNTARY H. Peter Anvin
2013-08-10 5:55 ` Mike Galbraith
2013-08-10 16:09 ` H. Peter Anvin
2013-08-10 16:43 ` Linus Torvalds
2013-08-10 17:18 ` H. Peter Anvin
2013-08-10 18:51 ` Linus Torvalds
2013-08-10 19:18 ` H. Peter Anvin
2013-08-10 20:26 ` H. Peter Anvin
2013-08-10 23:00 ` H. Peter Anvin
2013-08-11 4:17 ` Mike Galbraith
2013-08-11 4:27 ` H. Peter Anvin
2013-08-11 4:36 ` Mike Galbraith
2013-08-11 4:57 ` H. Peter Anvin
2013-08-11 5:58 ` Mike Galbraith
2013-08-13 18:09 ` H. Peter Anvin
2013-08-13 18:12 ` Andi Kleen
2013-08-14 18:27 ` Michael S. Tsirkin
2013-08-14 22:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376089460-5459-13-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).