From: Nathan Zimmer <nzimmer@sgi.com>
To: hpa@zytor.com, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, holt@sgi.com,
nzimmer@sgi.com, rob@landley.net, travis@sgi.com,
daniel@numascale-asia.com, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, yinghai@kernel.org, mgorman@suse.de
Subject: [RFC v3 1/5] memblock: Introduce a for_each_reserved_mem_region iterator.
Date: Mon, 12 Aug 2013 16:54:36 -0500 [thread overview]
Message-ID: <1376344480-156708-2-git-send-email-nzimmer@sgi.com> (raw)
In-Reply-To: <1376344480-156708-1-git-send-email-nzimmer@sgi.com>
From: Robin Holt <holt@sgi.com>
As part of initializing struct page's in 2MiB chunks, we noticed that
at the end of free_all_bootmem(), there was nothing which had forced
the reserved/allocated 4KiB pages to be initialized.
This helper function will be used for that expansion.
Signed-off-by: Robin Holt <holt@sgi.com>
Signed-off-by: Nathan Zimmer <nzimmer@sgi.com>
To: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Linux MM <linux-mm@kvack.org>
Cc: Rob Landley <rob@landley.net>
Cc: Mike Travis <travis@sgi.com>
Cc: Daniel J Blueman <daniel@numascale-asia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>
---
include/linux/memblock.h | 18 ++++++++++++++++++
mm/memblock.c | 32 ++++++++++++++++++++++++++++++++
2 files changed, 50 insertions(+)
diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index f388203..e99bbd1 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -118,6 +118,24 @@ void __next_free_mem_range_rev(u64 *idx, int nid, phys_addr_t *out_start,
i != (u64)ULLONG_MAX; \
__next_free_mem_range_rev(&i, nid, p_start, p_end, p_nid))
+void __next_reserved_mem_region(u64 *idx, phys_addr_t *out_start,
+ phys_addr_t *out_end);
+
+/**
+ * for_earch_reserved_mem_region - iterate over all reserved memblock areas
+ * @i: u64 used as loop variable
+ * @p_start: ptr to phys_addr_t for start address of the range, can be %NULL
+ * @p_end: ptr to phys_addr_t for end address of the range, can be %NULL
+ *
+ * Walks over reserved areas of memblock in. Available as soon as memblock
+ * is initialized.
+ */
+#define for_each_reserved_mem_region(i, p_start, p_end) \
+ for (i = 0UL, \
+ __next_reserved_mem_region(&i, p_start, p_end); \
+ i != (u64)ULLONG_MAX; \
+ __next_reserved_mem_region(&i, p_start, p_end))
+
#ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP
int memblock_set_node(phys_addr_t base, phys_addr_t size, int nid);
diff --git a/mm/memblock.c b/mm/memblock.c
index c5fad93..0d7d6e7 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -564,6 +564,38 @@ int __init_memblock memblock_reserve(phys_addr_t base, phys_addr_t size)
}
/**
+ * __next_reserved_mem_region - next function for for_each_reserved_region()
+ * @idx: pointer to u64 loop variable
+ * @out_start: ptr to phys_addr_t for start address of the region, can be %NULL
+ * @out_end: ptr to phys_addr_t for end address of the region, can be %NULL
+ *
+ * Iterate over all reserved memory regions.
+ */
+void __init_memblock __next_reserved_mem_region(u64 *idx,
+ phys_addr_t *out_start,
+ phys_addr_t *out_end)
+{
+ struct memblock_type *rsv = &memblock.reserved;
+
+ if (*idx >= 0 && *idx < rsv->cnt) {
+ struct memblock_region *r = &rsv->regions[*idx];
+ phys_addr_t base = r->base;
+ phys_addr_t size = r->size;
+
+ if (out_start)
+ *out_start = base;
+ if (out_end)
+ *out_end = base + size - 1;
+
+ *idx += 1;
+ return;
+ }
+
+ /* signal end of iteration */
+ *idx = ULLONG_MAX;
+}
+
+/**
* __next_free_mem_range - next function for for_each_free_mem_range()
* @idx: pointer to u64 loop variable
* @nid: nid: node selector, %MAX_NUMNODES for all nodes
--
1.8.2.1
next prev parent reply other threads:[~2013-08-12 21:54 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 2:03 [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator Robin Holt
2013-07-12 2:03 ` [RFC 1/4] memblock: Introduce a for_each_reserved_mem_region iterator Robin Holt
2013-07-12 2:03 ` [RFC 2/4] Have __free_pages_memory() free in larger chunks Robin Holt
2013-07-12 7:45 ` Robin Holt
2013-07-13 3:08 ` Yinghai Lu
2013-07-16 13:02 ` Sam Ben
2013-07-23 15:32 ` Johannes Weiner
2013-07-12 2:03 ` [RFC 3/4] Seperate page initialization into a separate function Robin Holt
2013-07-13 3:06 ` Yinghai Lu
2013-07-15 3:19 ` Robin Holt
2013-07-12 2:03 ` [RFC 4/4] Sparse initialization of struct page array Robin Holt
2013-07-13 4:19 ` Yinghai Lu
2013-07-13 4:39 ` H. Peter Anvin
2013-07-13 5:31 ` Yinghai Lu
2013-07-13 5:38 ` H. Peter Anvin
2013-07-15 14:08 ` Nathan Zimmer
2013-07-15 17:45 ` Nathan Zimmer
2013-07-15 17:54 ` H. Peter Anvin
2013-07-15 18:26 ` Robin Holt
2013-07-15 18:29 ` H. Peter Anvin
2013-07-23 8:32 ` Ingo Molnar
2013-07-23 11:09 ` Robin Holt
2013-07-23 11:15 ` Robin Holt
2013-07-23 11:41 ` Robin Holt
2013-07-23 11:50 ` Robin Holt
2013-07-16 10:26 ` Robin Holt
2013-07-25 2:25 ` Robin Holt
2013-07-25 12:50 ` Yinghai Lu
2013-07-25 13:42 ` Robin Holt
2013-07-25 13:52 ` Yinghai Lu
2013-07-15 21:30 ` Andrew Morton
2013-07-16 10:38 ` Robin Holt
2013-07-12 8:27 ` [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator Ingo Molnar
2013-07-12 8:47 ` boot tracing Borislav Petkov
2013-07-12 8:53 ` Ingo Molnar
2013-07-15 1:38 ` Sam Ben
2013-07-23 8:18 ` Ingo Molnar
2013-07-12 9:19 ` [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator Robert Richter
2013-07-15 15:16 ` Robin Holt
2013-07-16 8:55 ` Joonsoo Kim
2013-07-16 9:08 ` Borislav Petkov
2013-07-23 8:20 ` Ingo Molnar
2013-07-15 15:00 ` Robin Holt
2013-07-17 5:17 ` Sam Ben
2013-07-17 9:30 ` Robin Holt
2013-07-19 23:51 ` Yinghai Lu
2013-07-22 6:13 ` Robin Holt
2013-08-02 17:44 ` [RFC v2 0/5] " Nathan Zimmer
2013-08-02 17:44 ` [RFC v2 1/5] memblock: Introduce a for_each_reserved_mem_region iterator Nathan Zimmer
2013-08-02 17:44 ` [RFC v2 2/5] Have __free_pages_memory() free in larger chunks Nathan Zimmer
2013-08-02 17:44 ` [RFC v2 3/5] Move page initialization into a separate function Nathan Zimmer
2013-08-02 17:44 ` [RFC v2 4/5] Only set page reserved in the memblock region Nathan Zimmer
2013-08-03 20:04 ` Nathan Zimmer
2013-08-02 17:44 ` [RFC v2 5/5] Sparse initialization of struct page array Nathan Zimmer
2013-08-05 9:58 ` [RFC v2 0/5] Transparent on-demand struct page initialization embedded in the buddy allocator Ingo Molnar
2013-08-12 21:54 ` [RFC v3 " Nathan Zimmer
2013-08-12 21:54 ` Nathan Zimmer [this message]
2013-08-12 21:54 ` [RFC v3 2/5] Have __free_pages_memory() free in larger chunks Nathan Zimmer
2013-08-12 21:54 ` [RFC v3 3/5] Move page initialization into a separate function Nathan Zimmer
2013-08-12 21:54 ` [RFC v3 4/5] Only set page reserved in the memblock region Nathan Zimmer
2013-08-12 21:54 ` [RFC v3 5/5] Sparse initialization of struct page array Nathan Zimmer
2013-08-13 10:58 ` [RFC v3 0/5] Transparent on-demand struct page initialization embedded in the buddy allocator Ingo Molnar
2013-08-13 17:09 ` Linus Torvalds
2013-08-13 17:23 ` H. Peter Anvin
2013-08-13 17:33 ` Mike Travis
2013-08-13 17:51 ` Linus Torvalds
2013-08-13 18:04 ` Mike Travis
2013-08-13 19:06 ` Mike Travis
2013-08-13 20:24 ` Yinghai Lu
2013-08-13 20:37 ` Mike Travis
2013-08-13 21:35 ` Nathan Zimmer
2013-08-13 23:10 ` Nathan Zimmer
2013-08-13 23:55 ` Linus Torvalds
2013-08-14 11:27 ` Ingo Molnar
2013-08-14 11:05 ` Ingo Molnar
2013-08-14 22:15 ` Nathan Zimmer
2013-08-16 16:36 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376344480-156708-2-git-send-email-nzimmer@sgi.com \
--to=nzimmer@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@numascale-asia.com \
--cc=gregkh@linuxfoundation.org \
--cc=holt@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=rob@landley.net \
--cc=travis@sgi.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).