public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] BDI: Provide backing device capability information
Date: Thu, 03 Mar 2005 13:38:15 +0000	[thread overview]
Message-ID: <13767.1109857095@redhat.com> (raw)
In-Reply-To: <20050302135146.2248c7e5.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:

> 
> > +#define BDI_CAP_MAP_COPY	0x00000001	/* Copy can be mapped (MAP_PRIVATE) */
> > +#define BDI_CAP_MAP_DIRECT	0x00000002	/* Can be mapped directly (MAP_SHARED) */
> 
> Why not make these bitfields as well?

Because I want to copy the capabilities mask (including these variables) into
a variable in the nommu mmap implementation and eliminate various bits from
that variable under certain conditions.

Making these into bitfields would result in having to use three variables
instead of just the one.

David


  parent reply	other threads:[~2005-03-03 13:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02 15:50 Improving mmap() support for !MMU further David Howells
2005-03-02 17:07 ` Andrew Morton
2005-03-02 21:34   ` [PATCH 1/2] BDI: Provide backing device capability information David Howells
2005-03-02 21:51     ` Andrew Morton
2005-03-02 22:28       ` Linus Torvalds
2005-03-02 22:39         ` Andrew Morton
2005-03-03 13:42           ` David Howells
2005-03-03 20:33             ` Andrew Morton
2005-03-03 13:38       ` David Howells [this message]
2005-03-03 20:34         ` Andrew Morton
2005-03-07 11:23           ` David Howells
2005-03-07 11:37             ` Andrew Morton
2005-03-07 11:43               ` David Howells
2005-03-07 11:47                 ` Andrew Morton
2005-03-07 11:51                   ` David Howells
2005-03-07 12:10                     ` Andrew Morton
2005-03-07 12:25                       ` David Howells
2005-03-07 14:05                       ` David Howells
2005-03-07 15:21                         ` Miklos Szeredi
2005-03-07 15:41                           ` David Howells
2005-03-07 15:45                             ` Miklos Szeredi
2005-03-07 16:06                               ` David Howells
2005-03-07 16:15                                 ` Miklos Szeredi
2005-03-07 20:14                                   ` Andrew Morton
2005-03-08 14:12                                     ` [PATCH 1/2] BDI: Provide backing device capability information [try #3] David Howells
2005-03-09  0:37                                       ` Andrew Morton
2005-03-09 10:27                                         ` David Howells
2005-03-02 21:41   ` [PATCH 2/2] BDI: Improve nommu mmap support David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13767.1109857095@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=davidm@snapgear.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox