From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com,
sbw@mit.edu, "Bjørn Mork" <bjorn@mork.no>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 06/11] rcu: Switch to exedited grace periods for suspend as well as hibernation
Date: Sat, 17 Aug 2013 18:37:51 -0700 [thread overview]
Message-ID: <1376789876-27594-6-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1376789876-27594-1-git-send-email-paulmck@linux.vnet.ibm.com>
From: Bjørn Mork <bjorn@mork.no>
Commit 587ff2cf ("rcu: Expedite grace periods during suspend/resume")
enabled expedited grace periods for hibernation, but not for suspend.
The same issue applies to both cases, so this commit simply applies the
same logic by adding additional cases to the switch statement.
Note that this commit also switches from PM_POST_RESTORE to the
combination of PM_POST_HIBERNATION and PM_POST_SUSPEND. A separate
patch from Borislav Petkov corrects the documentation to indicate that
this is necessary.
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/rcutree.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 405f2303..9184056 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -3050,10 +3050,12 @@ static int rcu_pm_notify(struct notifier_block *self,
{
switch (action) {
case PM_HIBERNATION_PREPARE:
+ case PM_SUSPEND_PREPARE:
if (nr_cpu_ids <= 256) /* Expediting bad for large systems. */
rcu_expedited = 1;
break;
- case PM_POST_RESTORE:
+ case PM_POST_HIBERNATION:
+ case PM_POST_SUSPEND:
rcu_expedited = 0;
break;
default:
--
1.8.1.5
next prev parent reply other threads:[~2013-08-18 1:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 1:37 [PATCH tip/core/rcu 0/11] Fixes for 3.12 Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 01/11] rcu: Expedite grace periods during suspend/resume Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 02/11] rcu: Expedite during suspend and resume only on smallish systems Paul E. McKenney
2013-08-18 3:18 ` Josh Triplett
2013-08-19 0:32 ` Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 03/11] rcu: Simplify debug-objects fixups Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 04/11] debugobjects: Make debug_object_activate() return status Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 05/11] rcu: Make call_rcu() leak callbacks for debug-object errors Paul E. McKenney
2013-08-18 1:37 ` Paul E. McKenney [this message]
2013-08-18 3:20 ` [PATCH tip/core/rcu 06/11] rcu: Switch to exedited grace periods for suspend as well as hibernation Josh Triplett
2013-08-19 0:33 ` Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 07/11] rcu: Avoid redundant grace-period kthread wakeups Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 08/11] rculist: list_first_or_null_rcu() should use list_entry_rcu() Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 09/11] rcu: Select IRQ_WORK from TREE_PREEMPT_RCU Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 10/11] rcu: Simplify _rcu_barrier() processing Paul E. McKenney
2013-08-18 1:37 ` [PATCH tip/core/rcu 11/11] jiffies: Avoid undefined behavior from signed overflow Paul E. McKenney
2013-08-18 3:23 ` Josh Triplett
2013-08-19 0:41 ` Paul E. McKenney
2013-08-19 1:20 ` Josh Triplett
2013-08-19 4:14 ` Paul E. McKenney
2013-08-18 3:17 ` [PATCH tip/core/rcu 01/11] rcu: Expedite grace periods during suspend/resume Josh Triplett
2013-08-18 9:34 ` Borislav Petkov
2013-08-19 0:29 ` Paul E. McKenney
2013-08-19 9:18 ` Borislav Petkov
2013-08-18 3:24 ` [PATCH tip/core/rcu 0/11] Fixes for 3.12 Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376789876-27594-6-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn@mork.no \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).