linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] mtd: MTD_NAND_DENALI should depend on HAS_DMA
@ 2013-08-18 11:03 Geert Uytterhoeven
  2013-08-19 15:17 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2013-08-18 11:03 UTC (permalink / raw)
  To: David Woodhouse, Artem Bityutskiy, Andrew Morton
  Cc: linux-mtd, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

drivers/built-in.o: In function `denali_remove':
drivers/mtd/nand/denali.c:1605: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `denali_read_page_raw':
drivers/mtd/nand/denali.c:1190: undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `denali_read_page':
drivers/mtd/nand/denali.c:1140: undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `write_page':
drivers/mtd/nand/denali.c:1051: undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `denali_init':
drivers/mtd/nand/denali.c:1433: undefined reference to `dma_set_mask'
drivers/mtd/nand/denali.c:1438: undefined reference to `dma_map_single'
drivers/mtd/nand/denali.c:1442: undefined reference to `dma_mapping_error'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mtd/nand/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 50543f1..25b8a91 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -43,6 +43,7 @@ config MTD_SM_COMMON
 
 config MTD_NAND_DENALI
         tristate "Support Denali NAND controller"
+	depends on HAS_DMA
         help
 	  Enable support for the Denali NAND controller.  This should be
 	  combined with either the PCI or platform drivers to provide device
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] mtd: MTD_NAND_DENALI should depend on HAS_DMA
  2013-08-18 11:03 [PATCH RESEND] mtd: MTD_NAND_DENALI should depend on HAS_DMA Geert Uytterhoeven
@ 2013-08-19 15:17 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2013-08-19 15:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: David Woodhouse, Andrew Morton, linux-mtd, linux-kernel

On Sun, 2013-08-18 at 13:03 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
> drivers/built-in.o: In function `denali_remove':
> drivers/mtd/nand/denali.c:1605: undefined reference to `dma_unmap_single'
> drivers/built-in.o: In function `denali_read_page_raw':
> drivers/mtd/nand/denali.c:1190: undefined reference to `dma_sync_single_for_cpu'
> drivers/built-in.o: In function `denali_read_page':
> drivers/mtd/nand/denali.c:1140: undefined reference to `dma_sync_single_for_cpu'
> drivers/built-in.o: In function `write_page':
> drivers/mtd/nand/denali.c:1051: undefined reference to `dma_sync_single_for_cpu'
> drivers/built-in.o: In function `denali_init':
> drivers/mtd/nand/denali.c:1433: undefined reference to `dma_set_mask'
> drivers/mtd/nand/denali.c:1438: undefined reference to `dma_map_single'
> drivers/mtd/nand/denali.c:1442: undefined reference to `dma_mapping_error'
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-19 15:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-18 11:03 [PATCH RESEND] mtd: MTD_NAND_DENALI should depend on HAS_DMA Geert Uytterhoeven
2013-08-19 15:17 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).