* [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list
@ 2013-08-18 12:34 Axel Lin
2013-08-18 12:40 ` [PATCH 2/2] pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list Axel Lin
2013-08-21 21:19 ` [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2013-08-18 12:34 UTC (permalink / raw)
To: Linus Walleij; +Cc: Haojian Zhuang, linux-kernel
This one is missed in commit 44d5f7bb "pinctrl: sink pinctrldev_list_mutex".
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index c8fcedb..c670527 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -392,6 +392,8 @@ static int pinctrl_get_device_gpio_range(unsigned gpio,
{
struct pinctrl_dev *pctldev = NULL;
+ mutex_lock(&pinctrldev_list_mutex);
+
/* Loop over the pin controllers */
list_for_each_entry(pctldev, &pinctrldev_list, node) {
struct pinctrl_gpio_range *range;
@@ -400,10 +402,13 @@ static int pinctrl_get_device_gpio_range(unsigned gpio,
if (range != NULL) {
*outdev = pctldev;
*outrange = range;
+ mutex_unlock(&pinctrldev_list_mutex);
return 0;
}
}
+ mutex_unlock(&pinctrldev_list_mutex);
+
return -EPROBE_DEFER;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list
2013-08-18 12:34 [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list Axel Lin
@ 2013-08-18 12:40 ` Axel Lin
2013-08-21 21:20 ` Linus Walleij
2013-08-21 21:19 ` [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2013-08-18 12:40 UTC (permalink / raw)
To: Linus Walleij; +Cc: Haojian Zhuang, linux-kernel
Hold pctldev->mutex mutex_lock when traverse the list.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index c670527..4adef2f 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -357,14 +357,17 @@ static bool pinctrl_ready_for_gpio_range(unsigned gpio)
/* Loop over the pin controllers */
list_for_each_entry(pctldev, &pinctrldev_list, node) {
/* Loop over the ranges */
+ mutex_lock(&pctldev->mutex);
list_for_each_entry(range, &pctldev->gpio_ranges, node) {
/* Check if any gpio range overlapped with gpio chip */
if (range->base + range->npins - 1 < chip->base ||
range->base > chip->base + chip->ngpio - 1)
continue;
+ mutex_unlock(&pctldev->mutex);
mutex_unlock(&pinctrldev_list_mutex);
return true;
}
+ mutex_unlock(&pctldev->mutex);
}
mutex_unlock(&pinctrldev_list_mutex);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list
2013-08-18 12:34 [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list Axel Lin
2013-08-18 12:40 ` [PATCH 2/2] pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list Axel Lin
@ 2013-08-21 21:19 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-08-21 21:19 UTC (permalink / raw)
To: Axel Lin; +Cc: Haojian Zhuang, linux-kernel@vger.kernel.org
On Sun, Aug 18, 2013 at 2:34 PM, Axel Lin <axel.lin@ingics.com> wrote:
> This one is missed in commit 44d5f7bb "pinctrl: sink pinctrldev_list_mutex".
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Good catch Axel!
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list
2013-08-18 12:40 ` [PATCH 2/2] pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list Axel Lin
@ 2013-08-21 21:20 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-08-21 21:20 UTC (permalink / raw)
To: Axel Lin; +Cc: Haojian Zhuang, linux-kernel@vger.kernel.org
On Sun, Aug 18, 2013 at 2:40 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Hold pctldev->mutex mutex_lock when traverse the list.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-21 21:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-18 12:34 [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list Axel Lin
2013-08-18 12:40 ` [PATCH 2/2] pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list Axel Lin
2013-08-21 21:20 ` Linus Walleij
2013-08-21 21:19 ` [PATCH 1/2] pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).