The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rob Landley <rob@landley.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	Richard Yao <ryao@gentoo.org>,
	chanho.min@lge.com,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Yann Collet o <yann.collet.73@gmail.com>
Subject: Re: Why are BSD-licensed LZ4 symbols GPL exported?
Date: Tue, 20 Aug 2013 15:07:08 -0700	[thread overview]
Message-ID: <1377036428.2016.85.camel@joe-AO722> (raw)
In-Reply-To: <1377035193.2016.81.camel@joe-AO722>

On Tue, 2013-08-20 at 14:46 -0700, Joe Perches wrote:
> Because your

Sorry, not your's but Matthew's.

I do think the MODULE_LICENSE should be "Dual BSD/GPL"
instead of merely "GPL" if for no other reason than
politeness to the original developer and the
license at the top of the files.

 * LZ4 - Fast LZ compression algorithm
 * Copyright (C) 2011-2012, Yann Collet.
 * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php)

---
 lib/lz4/lz4_compress.c   | 2 +-
 lib/lz4/lz4_decompress.c | 2 +-
 lib/lz4/lz4hc_compress.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/lz4/lz4_compress.c b/lib/lz4/lz4_compress.c
index fd94058..a4001ee 100644
--- a/lib/lz4/lz4_compress.c
+++ b/lib/lz4/lz4_compress.c
@@ -439,5 +439,5 @@ exit:
 }
 EXPORT_SYMBOL_GPL(lz4_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 compressor");
diff --git a/lib/lz4/lz4_decompress.c b/lib/lz4/lz4_decompress.c
index d3414ea..c45e685 100644
--- a/lib/lz4/lz4_decompress.c
+++ b/lib/lz4/lz4_decompress.c
@@ -321,6 +321,6 @@ exit_0:
 #ifndef STATIC
 EXPORT_SYMBOL_GPL(lz4_decompress_unknownoutputsize);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4 Decompressor");
 #endif
diff --git a/lib/lz4/lz4hc_compress.c b/lib/lz4/lz4hc_compress.c
index eb1a74f..59f26e6 100644
--- a/lib/lz4/lz4hc_compress.c
+++ b/lib/lz4/lz4hc_compress.c
@@ -535,5 +535,5 @@ exit:
 }
 EXPORT_SYMBOL_GPL(lz4hc_compress);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual BSD/GPL");
 MODULE_DESCRIPTION("LZ4HC compressor");



  reply	other threads:[~2013-08-20 22:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  2:19 Why are BSD-licensed LZ4 symbols GPL exported? Richard Yao
2013-08-16 21:45 ` [PATCH] Correct the LZ4 license Richard Laager
2013-08-17  1:24   ` Kyungsik Lee
2013-08-20 17:11 ` Why are BSD-licensed LZ4 symbols GPL exported? Matthew Garrett
2013-08-20 17:38   ` Joe Perches
2013-08-20 21:37     ` Rob Landley
2013-08-20 21:46       ` Joe Perches
2013-08-20 22:07         ` Joe Perches [this message]
2013-08-20 22:33         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377036428.2016.85.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=chanho.min@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rob@landley.net \
    --cc=ryao@gentoo.org \
    --cc=yann.collet.73@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox