From: Leon Ma <xindong.ma@intel.com>
To: gregkh@linuxfoundation.org, ccross@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com
Cc: xindong.ma@intel.com
Subject: [PATCH] LMK: Optimize lowmem_shrink
Date: Wed, 21 Aug 2013 09:41:05 +0800 [thread overview]
Message-ID: <1377049265.22148.7.camel@leonma-sh> (raw)
From: Leon Ma <xindong.ma@intel.com>
Date: Mon, 19 Aug 2013 14:22:38 +0800
Subject: [PATCH] LMK: Optimize lowmem_shrink.
By comparing with selected_oom_score_adj instead of min_score_adj,
we may do less calculation.
Signed-off-by: Leon Ma <xindong.ma@intel.com>
---
drivers/staging/android/lowmemorykiller.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index f6c05c9..cb944c5 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -126,7 +126,7 @@ static int lowmem_shrink(struct shrinker *s, struct shrink_control *sc)
return 0;
}
oom_score_adj = p->signal->oom_score_adj;
- if (oom_score_adj < min_score_adj) {
+ if (oom_score_adj < selected_oom_score_adj) {
task_unlock(p);
continue;
}
@@ -134,13 +134,9 @@ static int lowmem_shrink(struct shrinker *s, struct shrink_control *sc)
task_unlock(p);
if (tasksize <= 0)
continue;
- if (selected) {
- if (oom_score_adj < selected_oom_score_adj)
- continue;
- if (oom_score_adj == selected_oom_score_adj &&
- tasksize <= selected_tasksize)
- continue;
- }
+ if (selected && oom_score_adj == selected_oom_score_adj &&
+ tasksize <= selected_tasksize)
+ continue;
selected = p;
selected_tasksize = tasksize;
selected_oom_score_adj = oom_score_adj;
--
1.7.4.1
next reply other threads:[~2013-08-21 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 1:41 Leon Ma [this message]
2013-08-23 16:48 ` [PATCH] LMK: Optimize lowmem_shrink Greg KH
2013-08-23 21:20 ` Sergey Senozhatsky
-- strict thread matches above, loose matches on Subject: below --
2013-08-20 1:16 Leon Ma
2013-08-20 2:23 ` Colin Cross
2013-08-20 2:25 ` Colin Cross
2013-08-20 8:30 ` Dan Carpenter
2013-08-21 2:09 ` Ma, Xindong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377049265.22148.7.camel@leonma-sh \
--to=xindong.ma@intel.com \
--cc=ccross@android.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).