* [PATCH] pinctrl: rockchip: Simplify for loop iteration
@ 2013-08-21 2:28 Axel Lin
2013-08-21 22:32 ` Linus Walleij
2013-08-22 9:01 ` Heiko Stübner
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-08-21 2:28 UTC (permalink / raw)
To: Linus Walleij; +Cc: Heiko Stübner, linux-kernel
Just return once a match found makes the code simpler and shorter.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index c22457d..64ad0c0 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -167,18 +167,14 @@ static const inline struct rockchip_pin_group *pinctrl_name_to_group(
const struct rockchip_pinctrl *info,
const char *name)
{
- const struct rockchip_pin_group *grp = NULL;
int i;
for (i = 0; i < info->ngroups; i++) {
- if (strcmp(info->groups[i].name, name))
- continue;
-
- grp = &info->groups[i];
- break;
+ if (!strcmp(info->groups[i].name, name))
+ return &info->groups[i];
}
- return grp;
+ return NULL;
}
/*
@@ -204,17 +200,12 @@ static struct rockchip_pin_bank *bank_num_to_bank(
struct rockchip_pin_bank *b = info->ctrl->pin_banks;
int i;
- for (i = 0; i < info->ctrl->nr_banks; i++) {
+ for (i = 0; i < info->ctrl->nr_banks; i++, b++) {
if (b->bank_num == num)
- break;
-
- b++;
+ return b;
}
- if (b->bank_num != num)
- return ERR_PTR(-EINVAL);
-
- return b;
+ return ERR_PTR(-EINVAL);
}
/*
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Simplify for loop iteration
2013-08-21 2:28 [PATCH] pinctrl: rockchip: Simplify for loop iteration Axel Lin
@ 2013-08-21 22:32 ` Linus Walleij
2013-08-22 9:01 ` Heiko Stübner
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-08-21 22:32 UTC (permalink / raw)
To: Axel Lin; +Cc: Heiko Stübner, linux-kernel@vger.kernel.org
On Wed, Aug 21, 2013 at 4:28 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Just return once a match found makes the code simpler and shorter.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Obviously correct, and elegant so patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Simplify for loop iteration
2013-08-21 2:28 [PATCH] pinctrl: rockchip: Simplify for loop iteration Axel Lin
2013-08-21 22:32 ` Linus Walleij
@ 2013-08-22 9:01 ` Heiko Stübner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2013-08-22 9:01 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, linux-kernel
Am Mittwoch, 21. August 2013, 04:28:50 schrieb Axel Lin:
> Just return once a match found makes the code simpler and shorter.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
as I'm a bit late for an Ack it seems, I can only offer a thanks for making
this nicer :-)
Heiko
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 21 ++++++---------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index c22457d..64ad0c0 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -167,18 +167,14 @@ static const inline struct rockchip_pin_group
> *pinctrl_name_to_group( const struct rockchip_pinctrl *info,
> const char *name)
> {
> - const struct rockchip_pin_group *grp = NULL;
> int i;
>
> for (i = 0; i < info->ngroups; i++) {
> - if (strcmp(info->groups[i].name, name))
> - continue;
> -
> - grp = &info->groups[i];
> - break;
> + if (!strcmp(info->groups[i].name, name))
> + return &info->groups[i];
> }
>
> - return grp;
> + return NULL;
> }
>
> /*
> @@ -204,17 +200,12 @@ static struct rockchip_pin_bank *bank_num_to_bank(
> struct rockchip_pin_bank *b = info->ctrl->pin_banks;
> int i;
>
> - for (i = 0; i < info->ctrl->nr_banks; i++) {
> + for (i = 0; i < info->ctrl->nr_banks; i++, b++) {
> if (b->bank_num == num)
> - break;
> -
> - b++;
> + return b;
> }
>
> - if (b->bank_num != num)
> - return ERR_PTR(-EINVAL);
> -
> - return b;
> + return ERR_PTR(-EINVAL);
> }
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-22 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-21 2:28 [PATCH] pinctrl: rockchip: Simplify for loop iteration Axel Lin
2013-08-21 22:32 ` Linus Walleij
2013-08-22 9:01 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox