linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Max Filippov <jcmvbkbc@gmail.com>, NeilBrown <neilb@suse.de>,
	Jim Kukunas <james.t.kukunas@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: [PATCH v2 3/5] raid6/test: replace echo -e with printf
Date: Fri, 23 Aug 2013 00:25:23 +0400	[thread overview]
Message-ID: <1377203125-22934-4-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1377203125-22934-1-git-send-email-jcmvbkbc@gmail.com>

-e is a non-standard echo option, echo output is
implementation-dependent when it is used. Replace echo -e with printf as
suggested by POSIX echo manual.

Cc: NeilBrown <neilb@suse.de>
Cc: Jim Kukunas <james.t.kukunas@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
---
 lib/raid6/test/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
index 087332d..73b0151 100644
--- a/lib/raid6/test/Makefile
+++ b/lib/raid6/test/Makefile
@@ -28,7 +28,7 @@ ifeq ($(IS_X86),yes)
                     gcc -c -x assembler - >&/dev/null &&	\
                     rm ./-.o && echo -DCONFIG_AS_AVX2=1)
 else
-        HAS_ALTIVEC := $(shell echo -e '\#include <altivec.h>\nvector int a;' |\
+        HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
                          gcc -c -x c - >&/dev/null && \
                          rm ./-.o && echo yes)
         ifeq ($(HAS_ALTIVEC),yes)
-- 
1.7.7.6


  parent reply	other threads:[~2013-08-22 20:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 20:25 [PATCH v2 0/5] clean up echo -e usage Max Filippov
2013-08-22 20:25 ` [PATCH v2 1/5] xtensa: don't use echo -e needlessly Max Filippov
2013-08-22 20:25 ` [PATCH v2 2/5] x86: " Max Filippov
2013-08-22 20:25 ` Max Filippov [this message]
2013-08-22 20:25 ` [PATCH v2 4/5] scripts/checkkconfigsymbols.sh: replace echo -e with printf Max Filippov
2013-08-28 15:01   ` Michal Marek
2013-08-22 20:25 ` [PATCH v2 5/5] tools/perf/perf-archive.sh: " Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377203125-22934-4-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=hpa@zytor.com \
    --cc=james.t.kukunas@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=neilb@suse.de \
    --cc=sam@ravnborg.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).