From: Axel Lin <axel.lin@ingics.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Heiko Stübner" <heiko@sntech.de>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] pinctrl: rockchip: Remove non-reachable break statement
Date: Fri, 23 Aug 2013 14:28:43 +0800 [thread overview]
Message-ID: <1377239323.14131.1.camel@phoenix> (raw)
In-Reply-To: <1377239273.14131.0.camel@phoenix>
The break statement after return is non-reachable, remove them.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 7eb1249..319a64a 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -585,7 +585,6 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
return rockchip_set_pull(bank, pin - bank->pin_base, param);
- break;
case PIN_CONFIG_BIAS_PULL_UP:
case PIN_CONFIG_BIAS_PULL_DOWN:
case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT:
@@ -596,10 +595,8 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
return -EINVAL;
return rockchip_set_pull(bank, pin - bank->pin_base, param);
- break;
default:
return -ENOTSUPP;
- break;
}
return 0;
@@ -633,7 +630,6 @@ static int rockchip_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
break;
default:
return -ENOTSUPP;
- break;
}
return 0;
--
1.8.1.2
next prev parent reply other threads:[~2013-08-23 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 6:27 [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Axel Lin
2013-08-23 6:28 ` Axel Lin [this message]
2013-08-28 11:17 ` [PATCH 2/2] pinctrl: rockchip: Remove non-reachable break statement Linus Walleij
2013-08-28 11:16 ` [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377239323.14131.1.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox