From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: 黃清隆 <ching2048@areca.com.tw>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
billion@areca.com.tw
Subject: Re: [PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284
Date: Mon, 26 Aug 2013 14:18:38 +0400 [thread overview]
Message-ID: <1377512318.20958.5.camel@dabdike> (raw)
In-Reply-To: <7A2818CC441F4BCE96D3B1E70CC3D76B@chingDT>
On Mon, 2013-08-26 at 12:14 +0800, 黃清隆 wrote:
> From: Ching <ching2048@areca.com.tw>
>
> Support Areca new SATA Raid adapter ARC1214/1224/1264/1284.
> Modify maximum outstanding command number, notify command complete with auto
> request sense
> Signed-off-by: Ching <ching2048@areca.com.tw>
Checkpatch really doesn't like this:
total: 1 errors, 173 warnings, 7131 lines checked
I fixed up the error and the few relevant warnings. I don't really care
about the lines over 80 characters. However, if you're going to have
long lines, don't split strings (another checkpatch complaint). I'd
also like to see the spurious braces removed in a later patch, please.
The prinks without a KERN_ also need fixing.
James
next prev parent reply other threads:[~2013-08-26 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 4:14 [PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 黃清隆
2013-08-26 10:18 ` James Bottomley [this message]
2013-08-26 12:20 ` Tomas Henzl
-- strict thread matches above, loose matches on Subject: below --
2013-08-26 4:12 黃清隆
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377512318.20958.5.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=billion@areca.com.tw \
--cc=ching2048@areca.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox