* [PATCH 2/8] regulator: aat2870: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
@ 2013-09-03 6:19 ` Axel Lin
2013-09-03 10:16 ` jinyoungp
2013-09-03 6:20 ` [PATCH 3/8] regulator: ad5398: " Axel Lin
` (6 subsequent siblings)
7 siblings, 1 reply; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:19 UTC (permalink / raw)
To: Mark Brown; +Cc: Jin Park, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/aat2870-regulator.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
index 8b58763..1ca60ac 100644
--- a/drivers/regulator/aat2870-regulator.c
+++ b/drivers/regulator/aat2870-regulator.c
@@ -176,7 +176,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
config.driver_data = ri;
config.init_data = pdev->dev.platform_data;
- rdev = regulator_register(&ri->desc, &config);
+ rdev = devm_regulator_register(&pdev->dev, &ri->desc, &config);
if (IS_ERR(rdev)) {
dev_err(&pdev->dev, "Failed to register regulator %s\n",
ri->desc.name);
@@ -187,21 +187,12 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
return 0;
}
-static int aat2870_regulator_remove(struct platform_device *pdev)
-{
- struct regulator_dev *rdev = platform_get_drvdata(pdev);
-
- regulator_unregister(rdev);
- return 0;
-}
-
static struct platform_driver aat2870_regulator_driver = {
.driver = {
.name = "aat2870-regulator",
.owner = THIS_MODULE,
},
.probe = aat2870_regulator_probe,
- .remove = aat2870_regulator_remove,
};
static int __init aat2870_regulator_init(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/8] regulator: aat2870: Convert to devm_regulator_register
2013-09-03 6:19 ` [PATCH 2/8] regulator: aat2870: " Axel Lin
@ 2013-09-03 10:16 ` jinyoungp
0 siblings, 0 replies; 10+ messages in thread
From: jinyoungp @ 2013-09-03 10:16 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: Liam Girdwood, linux-kernel@vger.kernel.org
Acked-by: Jinyoung Park <jinyoungp@nvidia.com>
On 09/03/2013 03:19 PM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/aat2870-regulator.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> index 8b58763..1ca60ac 100644
> --- a/drivers/regulator/aat2870-regulator.c
> +++ b/drivers/regulator/aat2870-regulator.c
> @@ -176,7 +176,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> config.driver_data = ri;
> config.init_data = pdev->dev.platform_data;
>
> - rdev = regulator_register(&ri->desc, &config);
> + rdev = devm_regulator_register(&pdev->dev, &ri->desc, &config);
> if (IS_ERR(rdev)) {
> dev_err(&pdev->dev, "Failed to register regulator %s\n",
> ri->desc.name);
> @@ -187,21 +187,12 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int aat2870_regulator_remove(struct platform_device *pdev)
> -{
> - struct regulator_dev *rdev = platform_get_drvdata(pdev);
> -
> - regulator_unregister(rdev);
> - return 0;
> -}
> -
> static struct platform_driver aat2870_regulator_driver = {
> .driver = {
> .name = "aat2870-regulator",
> .owner = THIS_MODULE,
> },
> .probe = aat2870_regulator_probe,
> - .remove = aat2870_regulator_remove,
> };
>
> static int __init aat2870_regulator_init(void)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/8] regulator: ad5398: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
2013-09-03 6:19 ` [PATCH 2/8] regulator: aat2870: " Axel Lin
@ 2013-09-03 6:20 ` Axel Lin
2013-09-03 6:22 ` [PATCH 4/8] regulator: as3711: " Axel Lin
` (5 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:20 UTC (permalink / raw)
To: Mark Brown; +Cc: Sonic Zhang, Michael Hennerich, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/ad5398.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index 6b981b5..92f42fd 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -219,7 +219,6 @@ static int ad5398_probe(struct i2c_client *client,
struct ad5398_chip_info *chip;
const struct ad5398_current_data_format *df =
(struct ad5398_current_data_format *)id->driver_data;
- int ret;
if (!init_data)
return -EINVAL;
@@ -240,33 +239,21 @@ static int ad5398_probe(struct i2c_client *client,
chip->current_offset = df->current_offset;
chip->current_mask = (chip->current_level - 1) << chip->current_offset;
- chip->rdev = regulator_register(&ad5398_reg, &config);
+ chip->rdev = devm_regulator_register(&client->dev, &ad5398_reg,
+ &config);
if (IS_ERR(chip->rdev)) {
- ret = PTR_ERR(chip->rdev);
dev_err(&client->dev, "failed to register %s %s\n",
id->name, ad5398_reg.name);
- goto err;
+ return PTR_ERR(chip->rdev);
}
i2c_set_clientdata(client, chip);
dev_dbg(&client->dev, "%s regulator driver is registered.\n", id->name);
return 0;
-
-err:
- return ret;
-}
-
-static int ad5398_remove(struct i2c_client *client)
-{
- struct ad5398_chip_info *chip = i2c_get_clientdata(client);
-
- regulator_unregister(chip->rdev);
- return 0;
}
static struct i2c_driver ad5398_driver = {
.probe = ad5398_probe,
- .remove = ad5398_remove,
.driver = {
.name = "ad5398",
},
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/8] regulator: as3711: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
2013-09-03 6:19 ` [PATCH 2/8] regulator: aat2870: " Axel Lin
2013-09-03 6:20 ` [PATCH 3/8] regulator: ad5398: " Axel Lin
@ 2013-09-03 6:22 ` Axel Lin
2013-09-03 6:23 ` [PATCH 5/8] regulator: da903x: " Axel Lin
` (4 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:22 UTC (permalink / raw)
To: Mark Brown; +Cc: Guennadi Liakhovetski, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/as3711-regulator.c | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/regulator/as3711-regulator.c b/drivers/regulator/as3711-regulator.c
index 3da6bd6..101fc2e 100644
--- a/drivers/regulator/as3711-regulator.c
+++ b/drivers/regulator/as3711-regulator.c
@@ -374,33 +374,16 @@ static int as3711_regulator_probe(struct platform_device *pdev)
config.regmap = as3711->regmap;
config.of_node = of_node[id];
- rdev = regulator_register(&ri->desc, &config);
+ rdev = devm_regulator_register(&pdev->dev, &ri->desc, &config);
if (IS_ERR(rdev)) {
dev_err(&pdev->dev, "Failed to register regulator %s\n",
ri->desc.name);
- ret = PTR_ERR(rdev);
- goto eregreg;
+ return PTR_ERR(rdev);
}
reg->rdev = rdev;
}
platform_set_drvdata(pdev, regs);
return 0;
-
-eregreg:
- while (--id >= 0)
- regulator_unregister(regs[id].rdev);
-
- return ret;
-}
-
-static int as3711_regulator_remove(struct platform_device *pdev)
-{
- struct as3711_regulator *regs = platform_get_drvdata(pdev);
- int id;
-
- for (id = 0; id < AS3711_REGULATOR_NUM; ++id)
- regulator_unregister(regs[id].rdev);
- return 0;
}
static struct platform_driver as3711_regulator_driver = {
@@ -409,7 +392,6 @@ static struct platform_driver as3711_regulator_driver = {
.owner = THIS_MODULE,
},
.probe = as3711_regulator_probe,
- .remove = as3711_regulator_remove,
};
static int __init as3711_regulator_init(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/8] regulator: da903x: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
` (2 preceding siblings ...)
2013-09-03 6:22 ` [PATCH 4/8] regulator: as3711: " Axel Lin
@ 2013-09-03 6:23 ` Axel Lin
2013-09-03 6:24 ` [PATCH 6/8] regulator: da9052: " Axel Lin
` (3 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:23 UTC (permalink / raw)
To: Mark Brown; +Cc: Eric Miao, Mike Rapoport, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/da903x.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 2afa573..6de6885 100644
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -488,7 +488,7 @@ static int da903x_regulator_probe(struct platform_device *pdev)
config.init_data = pdev->dev.platform_data;
config.driver_data = ri;
- rdev = regulator_register(&ri->desc, &config);
+ rdev = devm_regulator_register(&pdev->dev, &ri->desc, &config);
if (IS_ERR(rdev)) {
dev_err(&pdev->dev, "failed to register regulator %s\n",
ri->desc.name);
@@ -499,21 +499,12 @@ static int da903x_regulator_probe(struct platform_device *pdev)
return 0;
}
-static int da903x_regulator_remove(struct platform_device *pdev)
-{
- struct regulator_dev *rdev = platform_get_drvdata(pdev);
-
- regulator_unregister(rdev);
- return 0;
-}
-
static struct platform_driver da903x_regulator_driver = {
.driver = {
.name = "da903x-regulator",
.owner = THIS_MODULE,
},
.probe = da903x_regulator_probe,
- .remove = da903x_regulator_remove,
};
static int __init da903x_regulator_init(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/8] regulator: da9052: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
` (3 preceding siblings ...)
2013-09-03 6:23 ` [PATCH 5/8] regulator: da903x: " Axel Lin
@ 2013-09-03 6:24 ` Axel Lin
2013-09-03 6:26 ` [PATCH 7/8] regulator: da9055: " Axel Lin
` (2 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:24 UTC (permalink / raw)
To: Mark Brown; +Cc: David Dajun Chen, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/da9052-regulator.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index 96b569a..25d3e47 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -389,8 +389,9 @@ static int da9052_regulator_probe(struct platform_device *pdev)
#endif
}
- regulator->rdev = regulator_register(®ulator->info->reg_desc,
- &config);
+ regulator->rdev = devm_regulator_register(&pdev->dev,
+ ®ulator->info->reg_desc,
+ &config);
if (IS_ERR(regulator->rdev)) {
dev_err(&pdev->dev, "failed to register regulator %s\n",
regulator->info->reg_desc.name);
@@ -402,17 +403,8 @@ static int da9052_regulator_probe(struct platform_device *pdev)
return 0;
}
-static int da9052_regulator_remove(struct platform_device *pdev)
-{
- struct da9052_regulator *regulator = platform_get_drvdata(pdev);
-
- regulator_unregister(regulator->rdev);
- return 0;
-}
-
static struct platform_driver da9052_regulator_driver = {
.probe = da9052_regulator_probe,
- .remove = da9052_regulator_remove,
.driver = {
.name = "da9052-regulator",
.owner = THIS_MODULE,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/8] regulator: da9055: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
` (4 preceding siblings ...)
2013-09-03 6:24 ` [PATCH 6/8] regulator: da9052: " Axel Lin
@ 2013-09-03 6:26 ` Axel Lin
2013-09-03 6:27 ` [PATCH 8/8] regulator: fan53555: " Axel Lin
2013-09-03 9:26 ` [PATCH 1/8] regulator: 88pm8607: " Mark Brown
7 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:26 UTC (permalink / raw)
To: Mark Brown; +Cc: David Dajun Chen, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/da9055-regulator.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c
index 3022109..9565a35 100644
--- a/drivers/regulator/da9055-regulator.c
+++ b/drivers/regulator/da9055-regulator.c
@@ -564,13 +564,13 @@ static int da9055_regulator_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- regulator->rdev = regulator_register(®ulator->info->reg_desc,
- &config);
+ regulator->rdev = devm_regulator_register(&pdev->dev,
+ ®ulator->info->reg_desc,
+ &config);
if (IS_ERR(regulator->rdev)) {
dev_err(&pdev->dev, "Failed to register regulator %s\n",
regulator->info->reg_desc.name);
- ret = PTR_ERR(regulator->rdev);
- return ret;
+ return PTR_ERR(regulator->rdev);
}
/* Only LDO 5 and 6 has got the over current interrupt */
@@ -588,7 +588,7 @@ static int da9055_regulator_probe(struct platform_device *pdev)
dev_err(&pdev->dev,
"Failed to request Regulator IRQ %d: %d\n",
irq, ret);
- goto err_regulator;
+ return ret;
}
}
}
@@ -596,24 +596,10 @@ static int da9055_regulator_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, regulator);
return 0;
-
-err_regulator:
- regulator_unregister(regulator->rdev);
- return ret;
-}
-
-static int da9055_regulator_remove(struct platform_device *pdev)
-{
- struct da9055_regulator *regulator = platform_get_drvdata(pdev);
-
- regulator_unregister(regulator->rdev);
-
- return 0;
}
static struct platform_driver da9055_regulator_driver = {
.probe = da9055_regulator_probe,
- .remove = da9055_regulator_remove,
.driver = {
.name = "da9055-regulator",
.owner = THIS_MODULE,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 8/8] regulator: fan53555: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
` (5 preceding siblings ...)
2013-09-03 6:26 ` [PATCH 7/8] regulator: da9055: " Axel Lin
@ 2013-09-03 6:27 ` Axel Lin
2013-09-03 9:26 ` [PATCH 1/8] regulator: 88pm8607: " Mark Brown
7 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2013-09-03 6:27 UTC (permalink / raw)
To: Mark Brown; +Cc: Yunfan Zhang, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/fan53555.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c
index f0e1ae5..3ce9663 100644
--- a/drivers/regulator/fan53555.c
+++ b/drivers/regulator/fan53555.c
@@ -218,7 +218,7 @@ static int fan53555_regulator_register(struct fan53555_device_info *di,
rdesc->vsel_mask = VSEL_NSEL_MASK;
rdesc->owner = THIS_MODULE;
- di->rdev = regulator_register(&di->desc, config);
+ di->rdev = devm_regulator_register(di->dev, &di->desc, config);
return PTR_RET(di->rdev);
}
@@ -291,14 +291,6 @@ static int fan53555_regulator_probe(struct i2c_client *client,
}
-static int fan53555_regulator_remove(struct i2c_client *client)
-{
- struct fan53555_device_info *di = i2c_get_clientdata(client);
-
- regulator_unregister(di->rdev);
- return 0;
-}
-
static const struct i2c_device_id fan53555_id[] = {
{"fan53555", -1},
{ },
@@ -309,7 +301,6 @@ static struct i2c_driver fan53555_regulator_driver = {
.name = "fan53555-regulator",
},
.probe = fan53555_regulator_probe,
- .remove = fan53555_regulator_remove,
.id_table = fan53555_id,
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register
2013-09-03 6:17 [PATCH 1/8] regulator: 88pm8607: Convert to devm_regulator_register Axel Lin
` (6 preceding siblings ...)
2013-09-03 6:27 ` [PATCH 8/8] regulator: fan53555: " Axel Lin
@ 2013-09-03 9:26 ` Mark Brown
7 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2013-09-03 9:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Haojian Zhuang, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 128 bytes --]
On Tue, Sep 03, 2013 at 02:17:36PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied all, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread