* Oddness in security/Makefile
@ 2013-09-09 15:41 Valdis Kletnieks
2013-09-10 13:58 ` Eric Paris
0 siblings, 1 reply; 3+ messages in thread
From: Valdis Kletnieks @ 2013-09-09 15:41 UTC (permalink / raw)
To: Linus Torvalds, James Morris, Stephen Smalley, Eric Paris
Cc: linux-kernel, linux-security-module
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
Seen in security/Makefile:
% git blame security/Makefile
...
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 15)
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 16) # Object file lists
da31894e (Eric Paris 2008-08-22 11:35:57 -0400 17) obj-$(CONFIG_SECURITY) += security.o capability.o
da31894e (Eric Paris 2008-08-22 11:35:57 -0400 18) obj-$(CONFIG_SECURITYFS) += inode.o
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 19) # Must precede capability.o in order to stack properly.
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 20) obj-$(CONFIG_SECURITY_SELINUX) += selinux/built-in.o
5915eb53 (Miklos Szeredi 2008-07-03 20:56:05 +0200 21) obj-$(CONFIG_SECURITY_SMACK) += smack/built-in.o
...
What's wrong with this picture? Line 19 looks more than slightly confused,
and it has been for several years....
[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Oddness in security/Makefile
2013-09-09 15:41 Oddness in security/Makefile Valdis Kletnieks
@ 2013-09-10 13:58 ` Eric Paris
2013-09-24 1:23 ` James Morris
0 siblings, 1 reply; 3+ messages in thread
From: Eric Paris @ 2013-09-10 13:58 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Linus Torvalds, James Morris, Stephen Smalley, linux-kernel,
linux-security-module
>From 4675ca3470e3c2e325c5be6d9a11f47ac0917537 Mon Sep 17 00:00:00 2001
From: Eric Paris <eparis@redhat.com>
Date: Tue, 10 Sep 2013 09:51:50 -0400
Subject: [PATCH] security: remove erroneous comment about capabilities.o link
ordering
Back when we had half ass LSM stacking we had to link capabilities.o
after bigger LSMs so that on initialization the bigger LSM would
register first and the capabilities module would be the one stacked as
the 'seconday'. Somewhere around 6f0f0fd496333777d53 (back in 2008) we
finally removed the last of the kinda module stacking code but this
comment in the makefile still lives today.
Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Signed-off-by: Eric Paris <eparis@redhat.com>
---
security/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/security/Makefile b/security/Makefile
index c26c81e..a5918e0 100644
--- a/security/Makefile
+++ b/security/Makefile
@@ -16,7 +16,6 @@ obj-$(CONFIG_MMU) += min_addr.o
# Object file lists
obj-$(CONFIG_SECURITY) += security.o capability.o
obj-$(CONFIG_SECURITYFS) += inode.o
-# Must precede capability.o in order to stack properly.
obj-$(CONFIG_SECURITY_SELINUX) += selinux/built-in.o
obj-$(CONFIG_SECURITY_SMACK) += smack/built-in.o
obj-$(CONFIG_AUDIT) += lsm_audit.o
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Oddness in security/Makefile
2013-09-10 13:58 ` Eric Paris
@ 2013-09-24 1:23 ` James Morris
0 siblings, 0 replies; 3+ messages in thread
From: James Morris @ 2013-09-24 1:23 UTC (permalink / raw)
To: Eric Paris
Cc: Valdis Kletnieks, Linus Torvalds, James Morris, Stephen Smalley,
linux-kernel, linux-security-module
On Tue, 10 Sep 2013, Eric Paris wrote:
> >From 4675ca3470e3c2e325c5be6d9a11f47ac0917537 Mon Sep 17 00:00:00 2001
> From: Eric Paris <eparis@redhat.com>
> Date: Tue, 10 Sep 2013 09:51:50 -0400
> Subject: [PATCH] security: remove erroneous comment about capabilities.o link
> ordering
>
> Back when we had half ass LSM stacking we had to link capabilities.o
> after bigger LSMs so that on initialization the bigger LSM would
> register first and the capabilities module would be the one stacked as
> the 'seconday'. Somewhere around 6f0f0fd496333777d53 (back in 2008) we
> finally removed the last of the kinda module stacking code but this
> comment in the makefile still lives today.
>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-24 1:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 15:41 Oddness in security/Makefile Valdis Kletnieks
2013-09-10 13:58 ` Eric Paris
2013-09-24 1:23 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox