Re: [PATCHSET] sysfs: disentangle kobject namespace handling from sysfs

Tejun Heo
2013-09-12T03:47:22Z

On Wed, Sep 11, 2013 at 08:37:23PM -0700, Eric W. Biederman wrote:
> At a practical level you probably just want to copy the good parts of
> the structure of sysfs, instead of attempting to share code.
>
> Sharing code is likely to get you into all kinds of problems with short
> term hacks.

What? Are you kidding me? This is one of the most basic principles
which should be followed. The problem is not doing proper modular
design from the get-go. You have it completely backwards.

> > I never really understood why namespace support was added the way it
> > was added. Namespace information is communicated to sysfs via
> > callbacks and back-queries to upper layer, which is a very unusual and
> > weird thing to do when all the involved operations are synchronous.
> > For example, a tagged attribute creation looks like the following.
>
> Then please ask.

I asked the first time around and the answer I got was basically "I
didn't want to go around updating differnet layers and adding stuffing
it in the ops struct is more convenient". Do you have a better reason
now?

> I don't have the time or energy to review these right now, and given the
> sweeping nature of the patches, and the dismissive attitude of the
> original design there is almost at least one stupid bug if not something
> worse.
>
> So until I have the energy to review these.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>

No, you don't get to have a say without actually doing the review.
You sure can ask for more time to review stuff as long as it's
reasonable. Why are things like this still not clear to you? You
have been doing this long enough.

> I am sorry but I don't have time to clean up after any more people
> touching sysfs when the break something. It does look like there are so
> possibly good things going on but..

If you wanna object, do it technically through proper review. That's
how it works.

Thanks.

--
tejun