The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Stephen Warren <swarren@nvidia.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] staging: nvec: adjust for mfd_add_devices() API change
Date: Wed, 12 Sep 2012 22:07 +0200	[thread overview]
Message-ID: <1378976.P27YKfEPUV@ax5200p> (raw)
In-Reply-To: <1347467160-22724-1-git-send-email-swarren@wwwdotorg.org>

On Wednesday 12 September 2012 10:26:00 Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
> added a new parameter to mfd_add_devices(), but missed updating the
> nvec driver in staging.
> 
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

wops, I somehow missed this one. Anyway, the patch looks fine.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>

> --
> Samuel, I wonder if this patch should be squashed into the commit mentioned
> above in the MFD tree?
> ---
>  drivers/staging/nvec/nvec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index b0972d0..24d8eeb 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -837,7 +837,7 @@ static int __devinit tegra_nvec_probe(struct
> platform_device *pdev) }
> 
>  	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
> -			      ARRAY_SIZE(nvec_devices), base, 0);
> +			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
>  	if (ret)
>  		dev_err(nvec->dev, "error adding subdevices\n");

  reply	other threads:[~2012-09-12 20:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 16:26 [PATCH] staging: nvec: adjust for mfd_add_devices() API change Stephen Warren
2012-09-12 20:07 ` Marc Dietrich [this message]
2012-09-14  4:46 ` Greg Kroah-Hartman
2012-09-14  7:56 ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378976.P27YKfEPUV@ax5200p \
    --to=marvin24@gmx.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox