[uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.12

[uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.12

[Steven Miao]

Hi Linus,

please pull blackfin updates for Linux 3.12, some minor bug fixes.

The following changes since commit 6e4664525b1db28f8c4e1130957f70a94c19213e:

  Linux 3.11 (2013-09-02 13:46:10 -0700)

are available in the git repository at:

  http://git.kernel.org/pub/scm/linux/kernel/git/realmz6/blackfin-linux.git tags/blackfin-for-linus

for you to fetch changes up to 08b67faa23fdd4df3f3f7bb06f0ad67b7366d11c:

  blackfin: Ignore generated uImages (2013-09-13 10:42:39 +0800)

----------------------------------------------------------------
blackfin updates for Linux 3.12

----------------------------------------------------------------
Mark Brown (1):
      blackfin: Ignore generated uImages

Scott Jiang (2):
      bf609: add adv7343 video encoder support
      bf609: adv7343: add S-Video and Component output support

Sonic Zhang (2):
      blackfin: scb: Add SCB1 to SCB9 config options and data.
      blackfin: Add STMMAC platform data to enable dwmac1000 driver on BF60x.

Steven Miao (2):
      blackfin: scb: Add system crossbar init code.
      clock: add stmmac clock for ethernet driver

 arch/blackfin/boot/.gitignore                      |    1 +
 arch/blackfin/include/asm/scb.h                    |   21 +
 arch/blackfin/kernel/setup.c                       |    6 +
 arch/blackfin/mach-bf609/Kconfig                   | 1655 ++++++++++++++++++++
 arch/blackfin/mach-bf609/Makefile                  |    1 +
 arch/blackfin/mach-bf609/boards/ezkit.c            |   91 ++
 arch/blackfin/mach-bf609/clock.c                   |   17 +
 .../mach-bf609/include/mach/defBF60x_base.h        |   10 +
 arch/blackfin/mach-bf609/scb.c                     |  363 +++++
 arch/blackfin/mach-common/Makefile                 |    1 +
 arch/blackfin/mach-common/scb-init.c               |   53 +
 11 files changed, 2219 insertions(+)
 create mode 100644 arch/blackfin/include/asm/scb.h
 create mode 100644 arch/blackfin/mach-bf609/scb.c
 create mode 100644 arch/blackfin/mach-common/scb-init.c

Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.12

[Linus Torvalds]

On Thu, Sep 12, 2013 at 10:12 PM, Steven Miao <realmz6@kernel.org> wrote:
>  arch/blackfin/mach-bf609/Kconfig                   | 1655 ++++++++++++++++++++

WTF? This is getting crazy. The blackfin board Kconfig files are being
used as a DT replacement. This can't go on.

                  Linus

Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.12

[Steven Miao]

Hi Linus,

On Fri, Sep 13, 2013 at 10:29 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Thu, Sep 12, 2013 at 10:12 PM, Steven Miao <realmz6@kernel.org> wrote:
>>  arch/blackfin/mach-bf609/Kconfig                   | 1655 ++++++++++++++++++++
>
> WTF? This is getting crazy. The blackfin board Kconfig files are being
> used as a DT replacement. This can't go on.
>
Yes, it's a little too long. The scb patch is meant to be used for
user to tuning the performance of the on-chip(bf609) system crossbar
by menuconfig.

-steven

>                   Linus

Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.12

[Sonic Zhang]

Hi Linus,

On Fri, Sep 13, 2013 at 10:29 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Thu, Sep 12, 2013 at 10:12 PM, Steven Miao <realmz6@kernel.org> wrote:
>>  arch/blackfin/mach-bf609/Kconfig                   | 1655 ++++++++++++++++++++
>
> WTF? This is getting crazy. The blackfin board Kconfig files are being
> used as a DT replacement. This can't go on.
>

I am sorry to put many config options into the Blackfin Kconfig file.
In the case this is not preferred, we will make sure no more device
config options are put into the Kconfig files.

Thanks for your guide.


Sonic

Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.12

[Linus Torvalds]

On Mon, Sep 16, 2013 at 1:28 AM, Sonic Zhang <sonic.adi@gmail.com> wrote:
>
> I am sorry to put many config options into the Blackfin Kconfig file.
> In the case this is not preferred, we will make sure no more device
> config options are put into the Kconfig files.

It's not so much "no more device config options", it's more a matter of level.

If it's a couple of core options in the SoC, what the heck, use
Kconfig. Many of your board files are pretty small and have one or two
device config options in them. That's fine.

It's when it's thousands of lines of Kconfig file (and that isn't even
comments or anything like that), then that's a sign that you should
start seriously thinking about using some proper device configuration.
Device-tree is the one most architectures use, but heck, maybe it's
overkill for blackfin.

                    Linus