linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	kvm@vger.kernel.org, gleb@redhat.com, jan.kiszka@siemens.com
Subject: [PATCH 0/3] KVM: Make kvm_lock non-raw
Date: Mon, 16 Sep 2013 16:06:10 +0200	[thread overview]
Message-ID: <1379340373-5135-1-git-send-email-pbonzini@redhat.com> (raw)

Paul Gortmaker reported a BUG on preempt-rt kernels, due to taking the
mmu_lock within the raw kvm_lock in mmu_shrink_scan.  He provided a
patch that shrunk the kvm_lock critical section so that the mmu_lock
critical section does not nest with it, but in the end there is no reason
for the vm_list to be protected by a raw spinlock.  Only manipulations
of kvm_usage_count and the consequent hardware_enable/disable operations
are not preemptable.

This small series thus splits the kvm_lock in the "raw" part and the
"non-raw" part.

Paul, could you please provide your Tested-by?

Thanks,

Paolo

Paolo Bonzini (3):
  KVM: cleanup (physical) CPU hotplug
  KVM: protect kvm_usage_count with its own spinlock
  KVM: Convert kvm_lock back to non-raw spinlock

 Documentation/virtual/kvm/locking.txt |  8 ++++--
 arch/x86/kvm/mmu.c                    |  4 +--
 arch/x86/kvm/x86.c                    |  8 +++---
 include/linux/kvm_host.h              |  2 +-
 virt/kvm/kvm_main.c                   | 51 ++++++++++++++++++-----------------
 5 files changed, 40 insertions(+), 33 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2013-09-16 14:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16 14:06 Paolo Bonzini [this message]
2013-09-16 14:06 ` [PATCH 1/3] KVM: cleanup (physical) CPU hotplug Paolo Bonzini
2013-09-17  7:57   ` Jan Kiszka
2013-09-17 23:19     ` Paolo Bonzini
2013-09-16 14:06 ` [PATCH 2/3] KVM: protect kvm_usage_count with its own spinlock Paolo Bonzini
2013-09-16 14:06 ` [PATCH 3/3] KVM: Convert kvm_lock back to non-raw spinlock Paolo Bonzini
2013-09-16 22:12 ` [PATCH 0/3] KVM: Make kvm_lock non-raw Paul Gortmaker
2013-09-20 17:51   ` Paul Gortmaker
2013-09-20 18:04     ` Jan Kiszka
2013-09-20 18:18       ` Paul Gortmaker
2013-09-20 18:27         ` Jan Kiszka
2013-09-21 20:26       ` Michael S. Tsirkin
2013-09-22  7:42 ` Gleb Natapov
2013-09-22  8:53   ` Paolo Bonzini
2013-09-22  9:53     ` Gleb Natapov
2013-09-23  6:30       ` Jan Kiszka
2013-09-23 13:36       ` Paul Gortmaker
2013-09-23 13:44         ` Paolo Bonzini
2013-09-23 14:59           ` Gleb Natapov
2013-09-23 15:05             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379340373-5135-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).