From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Stephen Warren <swarren@nvidia.com>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: "memory" binding issues
Date: Tue, 17 Sep 2013 11:37:14 +1000 [thread overview]
Message-ID: <1379381834.3721.63.camel@pasglop> (raw)
In-Reply-To: <CAOesGMjDFOThCYPgPq5mS8-Uk5Ye=omye329EKRsb-q_akTP4Q@mail.gmail.com>
On Mon, 2013-09-16 at 16:48 -0700, Olof Johansson wrote:
> On Mon, Sep 16, 2013 at 4:47 PM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > On Mon, 2013-09-16 at 15:48 -0700, Olof Johansson wrote:
> >> > A node that has a "reg" property should have the corresponding unit
> >> > address.
> >>
> >> No, absolutely _NOT_ a requirement. Unit address is only required if
> >> needed to disambiguate two properties with the same name.
> >>
> >> If there are no ambiguities, then leaving off the unit address is much
> >> preferred.
> >
> > I disagree :-)
>
> Well, good thing you've got your own arch to litter the device trees
> with unit specifiers in then. :)
Right :-) We tend to have multiple memory nodes on server anyway so it's
not a big deal.
> > Also this would be only true of our find_node_by_path was capable of
> > handling it, which it isn't. Thus you end up with generic code looking
> > for /memory and finding nothing ...
>
> Yes, this should be fixed.
Right, the whole thing becomes mostly a non-issue once that's fixed. My
main objection isn't that ARM doesn't use unit address specifiers. My
objection is that the binding documents no unit address :-) It should
instead document the unit address with a note indicating that it can be
omitted if there is no ambiguity.
But first, do we have a volunteer to fix the path parsing code ? Also do
we *really* need to keep the path parsing code for fdt ? IE. It would be
annoying to have to duplicate that code for before and after
expansion...
Cheers,
Ben.
> -Olof
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-17 1:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 2:57 "memory" binding issues Benjamin Herrenschmidt
2013-09-16 15:22 ` Kumar Gala
2013-09-16 22:42 ` Benjamin Herrenschmidt
2013-09-17 15:53 ` Kumar Gala
2013-09-16 16:17 ` Stephen Warren
2013-09-16 22:46 ` Benjamin Herrenschmidt
2013-09-16 22:48 ` Olof Johansson
2013-09-16 23:47 ` Benjamin Herrenschmidt
2013-09-16 23:48 ` Olof Johansson
2013-09-17 1:37 ` Benjamin Herrenschmidt [this message]
2013-09-17 7:56 ` Tomasz Figa
2013-09-17 16:43 ` Olof Johansson
2013-09-17 21:08 ` Frank Rowand
2013-09-17 21:15 ` Olof Johansson
2013-09-17 21:19 ` Tomasz Figa
2013-09-17 21:33 ` Olof Johansson
2013-09-17 23:04 ` Benjamin Herrenschmidt
2013-09-17 23:25 ` Olof Johansson
2013-09-17 21:56 ` Benjamin Herrenschmidt
2013-09-18 16:28 ` Stephen Warren
2013-09-19 0:29 ` David Gibson
2013-09-18 1:25 ` David Gibson
2013-09-18 1:31 ` Grant Likely
2013-09-18 1:38 ` Grant Likely
2013-09-18 8:08 ` Benjamin Herrenschmidt
2013-09-18 2:57 ` Grant Likely
2013-09-18 8:21 ` Benjamin Herrenschmidt
2013-09-27 15:42 ` Kumar Gala
2013-10-03 15:04 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2013-09-16 2:41 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379381834.3721.63.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox