* [PATCH 02/19] hv: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-23 12:01 ` Dan Carpenter
2013-09-21 22:27 ` [PATCH 03/19] infiniband: " Peter Senna Tschudin
` (17 subsequent siblings)
18 siblings, 1 reply; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: kys; +Cc: haiyangz, devel, linux-kernel, kernel-janitors,
Peter Senna Tschudin
The variable execute_shutdown is only assigned the values true and
false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/hv/hv_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index cb82233..fa37369 100644
--- a/drivers/hv/hv_util.c
+++ b/drivers/hv/hv_util.c
@@ -82,7 +82,7 @@ static void shutdown_onchannelcallback(void *context)
struct vmbus_channel *channel = context;
u32 recvlen;
u64 requestid;
- u8 execute_shutdown = false;
+ bool execute_shutdown = false;
u8 *shut_txf_buf = util_shutdown.recv_buffer;
struct shutdown_msg_data *shutdown_msg;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 02/19] hv: Change variable type to bool
2013-09-21 22:27 ` [PATCH 02/19] hv: " Peter Senna Tschudin
@ 2013-09-23 12:01 ` Dan Carpenter
0 siblings, 0 replies; 27+ messages in thread
From: Dan Carpenter @ 2013-09-23 12:01 UTC (permalink / raw)
To: Peter Senna Tschudin; +Cc: kys, devel, haiyangz, kernel-janitors, linux-kernel
On Sun, Sep 22, 2013 at 12:27:34AM +0200, Peter Senna Tschudin wrote:
> diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> index cb82233..fa37369 100644
> --- a/drivers/hv/hv_util.c
> +++ b/drivers/hv/hv_util.c
> @@ -82,7 +82,7 @@ static void shutdown_onchannelcallback(void *context)
> struct vmbus_channel *channel = context;
> u32 recvlen;
> u64 requestid;
> - u8 execute_shutdown = false;
> + bool execute_shutdown = false;
> u8 *shut_txf_buf = util_shutdown.recv_buffer;
>
The two spaces are meant so first letters 'r', 'r', 'e', and 's' are on
the same column. It should just be one space so we don't have to
re-align everything when we make a change like this.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 03/19] infiniband: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 02/19] hv: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 04/19] isdn: " Peter Senna Tschudin
` (16 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: roland
Cc: sean.hefty, hal.rosenstock, bgottumukkala, tj, peter.senna,
dan.carpenter, linux-rdma, linux-kernel, kernel-janitors
The variables found and is_uctx_pd are only assigned the values true
and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +-
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
index 56e0049..e30e342 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
@@ -120,7 +120,7 @@ static bool ocrdma_add_sgid(struct ocrdma_dev *dev, unsigned char *mac_addr,
static bool ocrdma_del_sgid(struct ocrdma_dev *dev, unsigned char *mac_addr,
bool is_vlan, u16 vlan_id)
{
- int found = false;
+ bool found = false;
int i;
union ib_gid sgid;
unsigned long flags;
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index 6e982bb..843d18b 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -537,7 +537,7 @@ struct ib_pd *ocrdma_alloc_pd(struct ib_device *ibdev,
struct ocrdma_pd *pd;
struct ocrdma_ucontext *uctx = NULL;
int status;
- u8 is_uctx_pd = false;
+ bool is_uctx_pd = false;
if (udata && context) {
uctx = get_ocrdma_ucontext(context);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 04/19] isdn: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 02/19] hv: " Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 03/19] infiniband: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 05/19] media: " Peter Senna Tschudin
` (15 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: mac; +Cc: isdn4linux, netdev, linux-kernel, kernel-janitors,
Peter Senna Tschudin
The variable noCh is only assigned the values true and false. Change
its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/isdn/hardware/eicon/message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c
index a82e542..05d889a 100644
--- a/drivers/isdn/hardware/eicon/message.c
+++ b/drivers/isdn/hardware/eicon/message.c
@@ -1207,7 +1207,7 @@ static byte connect_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a,
byte m;
static byte esc_chi[35] = {0x02, 0x18, 0x01};
static byte lli[2] = {0x01, 0x00};
- byte noCh = 0;
+ bool noCh = false;
word dir = 0;
byte *p_chi = "";
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 05/19] media: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (2 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 04/19] isdn: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 06/19] " Peter Senna Tschudin
` (14 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: m.chehab
Cc: hfvogt, crope, peter.senna, linux-media, linux-kernel,
kernel-janitors
The variable vco_select is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/media/tuners/fc0012.c | 2 +-
drivers/media/tuners/fc0013.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/tuners/fc0012.c b/drivers/media/tuners/fc0012.c
index f4d0e79..d74e920 100644
--- a/drivers/media/tuners/fc0012.c
+++ b/drivers/media/tuners/fc0012.c
@@ -139,7 +139,7 @@ static int fc0012_set_params(struct dvb_frontend *fe)
unsigned char reg[7], am, pm, multi, tmp;
unsigned long f_vco;
unsigned short xtal_freq_khz_2, xin, xdiv;
- int vco_select = false;
+ bool vco_select = false;
if (fe->callback) {
ret = fe->callback(priv->i2c, DVB_FRONTEND_COMPONENT_TUNER,
diff --git a/drivers/media/tuners/fc0013.c b/drivers/media/tuners/fc0013.c
index bd8f0f1..b416231 100644
--- a/drivers/media/tuners/fc0013.c
+++ b/drivers/media/tuners/fc0013.c
@@ -233,7 +233,7 @@ static int fc0013_set_params(struct dvb_frontend *fe)
unsigned char reg[7], am, pm, multi, tmp;
unsigned long f_vco;
unsigned short xtal_freq_khz_2, xin, xdiv;
- int vco_select = false;
+ bool vco_select = false;
if (fe->callback) {
ret = fe->callback(priv->i2c, DVB_FRONTEND_COMPONENT_TUNER,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 06/19] media: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (3 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 05/19] media: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 07/19] mmc: " Peter Senna Tschudin
` (13 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: m.chehab
Cc: sakari.ailus, hans.verkuil, peter.senna, linux-media,
linux-kernel, kernel-janitors
The variable frame_ready is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
This fails at checkpatch due initializing static variable to false.
I haven't changed the assignment.
drivers/media/usb/cpia2/cpia2_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c
index be17192..351a78a 100644
--- a/drivers/media/usb/cpia2/cpia2_usb.c
+++ b/drivers/media/usb/cpia2/cpia2_usb.c
@@ -209,7 +209,7 @@ static void cpia2_usb_complete(struct urb *urb)
{
int i;
unsigned char *cdata;
- static int frame_ready = false;
+ static bool frame_ready = false;
struct camera_data *cam = (struct camera_data *) urb->context;
if (urb->status!=0) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 07/19] mmc: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (4 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 06/19] " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 08/19] net: " Peter Senna Tschudin
` (12 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: cjb
Cc: tgih.jun, linkinjeon, kdorfman, ygardi, linux-mmc, linux-kernel,
kernel-janitors, Peter Senna Tschudin
The variable is_rpmb is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/mmc/card/block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 1a3163f..a5f5fb9 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -451,7 +451,7 @@ static int mmc_blk_ioctl_cmd(struct block_device *bdev,
struct mmc_request mrq = {NULL};
struct scatterlist sg;
int err;
- int is_rpmb = false;
+ bool is_rpmb = false;
u32 status = 0;
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 08/19] net: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (5 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 07/19] mmc: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 09/19] " Peter Senna Tschudin
` (11 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: jcliburn
Cc: chris.snook, jkosina, rdunlap, standby24x7, peter.senna, netdev,
linux-kernel, kernel-janitors
The variable ret is only assigned the values true and false.
The function atl1c_read_eeprom already returns bool. Change
ret type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
index 3ef7092..1cda49a 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
@@ -153,7 +153,7 @@ static int atl1c_get_permanent_address(struct atl1c_hw *hw)
bool atl1c_read_eeprom(struct atl1c_hw *hw, u32 offset, u32 *p_value)
{
int i;
- int ret = false;
+ bool ret = false;
u32 otp_ctrl_data;
u32 control;
u32 data;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 09/19] net: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (6 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 08/19] net: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-23 21:38 ` David Miller
2013-09-21 22:27 ` [PATCH 10/19] " Peter Senna Tschudin
` (10 subsequent siblings)
18 siblings, 1 reply; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: eilong; +Cc: netdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
The variable rc is only assigned the values true and false.
The function bnx2x_prev_is_path_marked already returns bool.
Change rc type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index fccfc1d..105cc80 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -9874,7 +9874,7 @@ static int bnx2x_prev_path_mark_eeh(struct bnx2x *bp)
static bool bnx2x_prev_is_path_marked(struct bnx2x *bp)
{
struct bnx2x_prev_path_list *tmp_list;
- int rc = false;
+ bool rc = false;
if (down_trylock(&bnx2x_prev_sem))
return false;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 10/19] net: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (7 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 09/19] " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 11/19] wireless: " Peter Senna Tschudin
` (9 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: hykim; +Cc: netdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
There is the rc variable on both myri10ge_ss_lock_napi and
myri10ge_ss_lock_poll functions. In both cases rc is only assigned the
values true and false. Both functions already return bool. Change rc
type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 149355b..7792264 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -934,7 +934,7 @@ static inline void myri10ge_ss_init_lock(struct myri10ge_slice_state *ss)
static inline bool myri10ge_ss_lock_napi(struct myri10ge_slice_state *ss)
{
- int rc = true;
+ bool rc = true;
spin_lock(&ss->lock);
if ((ss->state & SLICE_LOCKED)) {
WARN_ON((ss->state & SLICE_STATE_NAPI));
@@ -957,7 +957,7 @@ static inline void myri10ge_ss_unlock_napi(struct myri10ge_slice_state *ss)
static inline bool myri10ge_ss_lock_poll(struct myri10ge_slice_state *ss)
{
- int rc = true;
+ bool rc = true;
spin_lock_bh(&ss->lock);
if ((ss->state & SLICE_LOCKED)) {
ss->state |= SLICE_STATE_POLL_YIELD;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 11/19] wireless: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (8 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 10/19] " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-23 19:40 ` Bing Zhao
2013-09-21 22:27 ` [PATCH 12/19] " Peter Senna Tschudin
` (8 subsequent siblings)
18 siblings, 1 reply; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: bzhao
Cc: linville, linux-wireless, netdev, linux-kernel, kernel-janitors,
Peter Senna Tschudin
The variables cancel_scan_cmd, enable_data, hs_activate and valid are
only assigned the values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/wireless/mwifiex/cmdevt.c | 2 +-
drivers/net/wireless/mwifiex/join.c | 2 +-
drivers/net/wireless/mwifiex/sta_cmd.c | 2 +-
drivers/net/wireless/mwifiex/wmm.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c
index 2d76147..fb3fa18 100644
--- a/drivers/net/wireless/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/mwifiex/cmdevt.c
@@ -1048,7 +1048,7 @@ mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter)
struct cmd_ctrl_node *cmd_node = NULL, *tmp_node = NULL;
unsigned long cmd_flags;
unsigned long scan_pending_q_flags;
- uint16_t cancel_scan_cmd = false;
+ bool cancel_scan_cmd = false;
if ((adapter->curr_cmd) &&
(adapter->curr_cmd->wait_q_enabled)) {
diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c
index 9d7c0e6..717fbe2 100644
--- a/drivers/net/wireless/mwifiex/join.c
+++ b/drivers/net/wireless/mwifiex/join.c
@@ -621,7 +621,7 @@ int mwifiex_ret_802_11_associate(struct mwifiex_private *priv,
int ret = 0;
struct ieee_types_assoc_rsp *assoc_rsp;
struct mwifiex_bssdescriptor *bss_desc;
- u8 enable_data = true;
+ bool enable_data = true;
u16 cap_info, status_code;
assoc_rsp = (struct ieee_types_assoc_rsp *) &resp->params;
diff --git a/drivers/net/wireless/mwifiex/sta_cmd.c b/drivers/net/wireless/mwifiex/sta_cmd.c
index c0268b5..7d66018 100644
--- a/drivers/net/wireless/mwifiex/sta_cmd.c
+++ b/drivers/net/wireless/mwifiex/sta_cmd.c
@@ -327,7 +327,7 @@ mwifiex_cmd_802_11_hs_cfg(struct mwifiex_private *priv,
{
struct mwifiex_adapter *adapter = priv->adapter;
struct host_cmd_ds_802_11_hs_cfg_enh *hs_cfg = &cmd->params.opt_hs_cfg;
- u16 hs_activate = false;
+ bool hs_activate = false;
if (!hscfg_param)
/* New Activate command */
diff --git a/drivers/net/wireless/mwifiex/wmm.c b/drivers/net/wireless/mwifiex/wmm.c
index 2e8f9cd..8f8fea0 100644
--- a/drivers/net/wireless/mwifiex/wmm.c
+++ b/drivers/net/wireless/mwifiex/wmm.c
@@ -708,7 +708,7 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,
{
u8 *curr = (u8 *) &resp->params.get_wmm_status;
uint16_t resp_len = le16_to_cpu(resp->size), tlv_len;
- int valid = true;
+ bool valid = true;
struct mwifiex_ie_types_data *tlv_hdr;
struct mwifiex_ie_types_wmm_queue_status *tlv_wmm_qstatus;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* RE: [PATCH 11/19] wireless: Change variable type to bool
2013-09-21 22:27 ` [PATCH 11/19] wireless: " Peter Senna Tschudin
@ 2013-09-23 19:40 ` Bing Zhao
0 siblings, 0 replies; 27+ messages in thread
From: Bing Zhao @ 2013-09-23 19:40 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Peter,
Thanks for your patch.
> The variables cancel_scan_cmd, enable_data, hs_activate and valid are
> only assigned the values true and false. Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> identifier b;
> @@
> - T
> + bool
> b = ...;
> ... when any
> b = \(true\|false\)
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Bing Zhao <bzhao@marvell.com>
Thanks,
Bing
> ---
> drivers/net/wireless/mwifiex/cmdevt.c | 2 +-
> drivers/net/wireless/mwifiex/join.c | 2 +-
> drivers/net/wireless/mwifiex/sta_cmd.c | 2 +-
> drivers/net/wireless/mwifiex/wmm.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 12/19] wireless: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (9 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 11/19] wireless: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-22 8:22 ` Joe Perches
2013-09-24 10:54 ` Kalle Valo
2013-09-21 22:27 ` [PATCH 13/19] rtc: " Peter Senna Tschudin
` (7 subsequent siblings)
18 siblings, 2 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: Larry.Finger
Cc: chaoming_li, linville, linux-wireless, netdev, linux-kernel,
kernel-janitors, Peter Senna Tschudin
The variable continual is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/wireless/rtlwifi/efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/efuse.c b/drivers/net/wireless/rtlwifi/efuse.c
index 838a1ed..63d370d 100644
--- a/drivers/net/wireless/rtlwifi/efuse.c
+++ b/drivers/net/wireless/rtlwifi/efuse.c
@@ -1203,7 +1203,7 @@ static void efuse_power_switch(struct ieee80211_hw *hw, u8 write, u8 pwrstate)
static u16 efuse_get_current_size(struct ieee80211_hw *hw)
{
- int continual = true;
+ bool continual = true;
u16 efuse_addr = 0;
u8 hworden;
u8 efuse_data, word_cnts;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 12/19] wireless: Change variable type to bool
2013-09-21 22:27 ` [PATCH 12/19] " Peter Senna Tschudin
@ 2013-09-22 8:22 ` Joe Perches
2013-09-24 10:54 ` Kalle Valo
1 sibling, 0 replies; 27+ messages in thread
From: Joe Perches @ 2013-09-22 8:22 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Larry.Finger, chaoming_li, linville, linux-wireless, netdev,
linux-kernel, kernel-janitors
On Sun, 2013-09-22 at 00:27 +0200, Peter Senna Tschudin wrote:
> The variable continual is only assigned the values true and false.
> Change its type to bool.
[]
> diff --git a/drivers/net/wireless/rtlwifi/efuse.c b/drivers/net/wireless/rtlwifi/efuse.c
[]
> @@ -1203,7 +1203,7 @@ static void efuse_power_switch(struct ieee80211_hw *hw, u8 write, u8 pwrstate)
>
> static u16 efuse_get_current_size(struct ieee80211_hw *hw)
> {
> - int continual = true;
> + bool continual = true;
> u16 efuse_addr = 0;
> u8 hworden;
> u8 efuse_data, word_cnts;
Yes, this could use bool, but would probably be better
written without continual at all
as it is before this patch:
static u16 efuse_get_current_size(struct ieee80211_hw *hw)
{
int continual = true;
u16 efuse_addr = 0;
u8 hworden;
u8 efuse_data, word_cnts;
while (continual && efuse_one_byte_read(hw, efuse_addr, &efuse_data)
&& (efuse_addr < EFUSE_MAX_SIZE)) {
if (efuse_data != 0xFF) {
hworden = efuse_data & 0x0F;
word_cnts = efuse_calculate_word_cnts(hworden);
efuse_addr = efuse_addr + (word_cnts * 2) + 1;
} else {
continual = false;
}
}
return efuse_addr;
}
I think writing it without continual, which is effectively
an ersatz "break", would be better
Something like:
static u16 efuse_get_current_size(struct ieee80211_hw *hw)
{
u16 efuse_addr = 0;
u8 hworden;
u8 efuse_data, word_cnts;
while (efuse_one_byte_read(hw, efuse_addr, &efuse_data) &&
(efuse_addr < EFUSE_MAX_SIZE) {
if (efuse_data == 0xff)
break;
hworden = efuse_data & 0x0F;
word_cnts = efuse_calculate_word_cnts(hworden);
efuse_addr = efuse_addr + (word_cnts * 2) + 1;
}
return efuse_addr;
}
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH 12/19] wireless: Change variable type to bool
2013-09-21 22:27 ` [PATCH 12/19] " Peter Senna Tschudin
2013-09-22 8:22 ` Joe Perches
@ 2013-09-24 10:54 ` Kalle Valo
1 sibling, 0 replies; 27+ messages in thread
From: Kalle Valo @ 2013-09-24 10:54 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Larry.Finger, chaoming_li, linville, linux-wireless, netdev,
linux-kernel, kernel-janitors
Peter Senna Tschudin <peter.senna@gmail.com> writes:
> The variable continual is only assigned the values true and false.
> Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> identifier b;
> @@
> - T
> + bool
> b = ...;
> ... when any
> b = \(true\|false\)
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please prefix the patch title with "rtlwifi:". We use "wireless:" for
changes to net/wireless.
--
Kalle Valo
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 13/19] rtc: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (10 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 12/19] " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 14/19] scsi: " Peter Senna Tschudin
` (6 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: a.zummo; +Cc: rtc-linux, linux-kernel, kernel-janitors, Peter Senna Tschudin
The variable want_irq is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/rtc/rtc-ds1307.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index ca18fd1..c8babcf 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -670,7 +670,7 @@ static int ds1307_probe(struct i2c_client *client,
int tmp;
const struct chip_desc *chip = &chips[id->driver_data];
struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
- int want_irq = false;
+ bool want_irq = false;
unsigned char *buf;
struct ds1307_platform_data *pdata = client->dev.platform_data;
static const int bbsqi_bitpos[] = {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 14/19] scsi: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (11 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 13/19] rtc: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 15/19] staging: " Peter Senna Tschudin
` (5 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: intel-linux-scu
Cc: lukasz.dorau, maciej.patelczyk, dave.jiang, JBottomley,
linux-scsi, linux-kernel, kernel-janitors, Peter Senna Tschudin
The variable success is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/scsi/isci/port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c
index 13098b0..26f8e5c 100644
--- a/drivers/scsi/isci/port.c
+++ b/drivers/scsi/isci/port.c
@@ -174,7 +174,7 @@ static void isci_port_link_up(struct isci_host *isci_host,
{
unsigned long flags;
struct sci_port_properties properties;
- unsigned long success = true;
+ bool success = true;
dev_dbg(&isci_host->pdev->dev,
"%s: isci_port = %p\n",
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 15/19] staging: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (12 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 14/19] scsi: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 23:15 ` Greg KH
2013-09-21 22:27 ` [PATCH 16/19] " Peter Senna Tschudin
` (4 subsequent siblings)
18 siblings, 1 reply; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: gregkh
Cc: maxtram95, yamanetoshi, viro, wfp5p, devel, linux-kernel,
kernel-janitors, Peter Senna Tschudin
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/staging/rtl8187se/r8180_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 5947a6f..35412d2 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -1704,7 +1704,7 @@ short rtl8180_tx(struct net_device *dev, u8 *txbuf, int len, int priority,
u16 RtsDur = 0;
u16 ThisFrameTime = 0;
u16 TxDescDuration = 0;
- u8 ownbit_flag = false;
+ bool ownbit_flag = false;
switch (priority) {
case MANAGE_PRIORITY:
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 15/19] staging: Change variable type to bool
2013-09-21 22:27 ` [PATCH 15/19] staging: " Peter Senna Tschudin
@ 2013-09-21 23:15 ` Greg KH
0 siblings, 0 replies; 27+ messages in thread
From: Greg KH @ 2013-09-21 23:15 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: maxtram95, yamanetoshi, viro, wfp5p, devel, linux-kernel,
kernel-janitors
On Sun, Sep 22, 2013 at 12:27:47AM +0200, Peter Senna Tschudin wrote:
> The variable ownbit_flag is only assigned the values true and false.
> Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> identifier b;
> @@
> - T
> + bool
> b = ...;
> ... when any
> b = \(true\|false\)
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/staging/rtl8187se/r8180_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent me 3 patches with the exact same subject: line, which doesn't
bode well for the changelog. You should update your script to put the
driver name in the subject: to make it more unique and easier to
identify in the future. I'll fix these 3 up for now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 16/19] staging: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (13 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 15/19] staging: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 17/19] " Peter Senna Tschudin
` (3 subsequent siblings)
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: forest
Cc: gregkh, more.andres, tvboxspy, dan.carpenter, peter.senna,
hemaklnce, devel, linux-kernel, kernel-janitors
The variables bMultiBand and bKeyTableFull are only assigned the
values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/staging/vt6656/channel.c | 2 +-
drivers/staging/vt6656/hostap.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/channel.c b/drivers/staging/vt6656/channel.c
index 5158ff4..e430b35 100644
--- a/drivers/staging/vt6656/channel.c
+++ b/drivers/staging/vt6656/channel.c
@@ -403,7 +403,7 @@ exit:
void CHvInitChannelTable(struct vnt_private *pDevice)
{
- int bMultiBand = false;
+ bool bMultiBand = false;
int ii;
for (ii = 1; ii <= CB_MAX_CHANNEL; ii++)
diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c
index c699a30..7d96fe7 100644
--- a/drivers/staging/vt6656/hostap.c
+++ b/drivers/staging/vt6656/hostap.c
@@ -414,7 +414,7 @@ static int hostap_set_encryption(struct vnt_private *pDevice,
int ret = 0;
s32 iNodeIndex = -1;
int ii;
- int bKeyTableFull = false;
+ bool bKeyTableFull = false;
u16 wKeyCtl = 0;
param->u.crypt.err = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 17/19] staging: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (14 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 16/19] " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-22 13:35 ` Pavel Machek
2013-09-21 22:27 ` [PATCH 18/19] nilfs2: " Peter Senna Tschudin
` (2 subsequent siblings)
18 siblings, 1 reply; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: pavel
Cc: gregkh, harsh1kumar, dan.carpenter, peter.senna, devel,
linux-kernel, kernel-janitors
The variable Trigger is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/staging/winbond/wb35tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
index 30a77cc..708c5b0 100644
--- a/drivers/staging/winbond/wb35tx.c
+++ b/drivers/staging/winbond/wb35tx.c
@@ -180,7 +180,7 @@ void Wb35Tx_CurrentTime(struct wbsoft_priv *adapter, u32 TimeCount)
{
struct hw_data *pHwData = &adapter->sHwData;
struct wb35_tx *pWb35Tx = &pHwData->Wb35Tx;
- unsigned char Trigger = false;
+ bool Trigger = false;
if (pWb35Tx->TxTimer > TimeCount)
Trigger = true;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 18/19] nilfs2: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (15 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 17/19] " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 19/19] net: " Peter Senna Tschudin
[not found] ` <43e0f3a4fb62473e9bdd308a8dc4490f@fmsmsx104.amr.corp.intel.com>
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: konishi.ryusuke
Cc: linux-nilfs, linux-kernel, kernel-janitors, Peter Senna Tschudin
The variable update_sr is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
fs/nilfs2/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
index bd88a74..669c809 100644
--- a/fs/nilfs2/segment.c
+++ b/fs/nilfs2/segment.c
@@ -1746,7 +1746,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci)
struct nilfs_segment_buffer *segbuf;
struct page *bd_page = NULL, *fs_page = NULL;
struct the_nilfs *nilfs = sci->sc_super->s_fs_info;
- int update_sr = false;
+ bool update_sr = false;
list_for_each_entry(segbuf, &sci->sc_write_logs, sb_list) {
struct buffer_head *bh;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH 19/19] net: Change variable type to bool
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
` (16 preceding siblings ...)
2013-09-21 22:27 ` [PATCH 18/19] nilfs2: " Peter Senna Tschudin
@ 2013-09-21 22:27 ` Peter Senna Tschudin
[not found] ` <43e0f3a4fb62473e9bdd308a8dc4490f@fmsmsx104.amr.corp.intel.com>
18 siblings, 0 replies; 27+ messages in thread
From: Peter Senna Tschudin @ 2013-09-21 22:27 UTC (permalink / raw)
To: davem
Cc: kuznet, jmorris, kaber, netdev, linux-kernel, kernel-janitors,
Peter Senna Tschudin
The variable fully_acked is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 25a89ea..fa17dce 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2970,7 +2970,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, int prior_fackets,
const struct inet_connection_sock *icsk = inet_csk(sk);
struct sk_buff *skb;
u32 now = tcp_time_stamp;
- int fully_acked = true;
+ bool fully_acked = true;
int flag = 0;
u32 pkts_acked = 0;
u32 reord = tp->packets_out;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 27+ messages in thread[parent not found: <43e0f3a4fb62473e9bdd308a8dc4490f@fmsmsx104.amr.corp.intel.com>]
* RE: [PATCH 14/19] scsi: Change variable type to bool
[not found] ` <43e0f3a4fb62473e9bdd308a8dc4490f@fmsmsx104.amr.corp.intel.com>
@ 2013-09-23 14:11 ` Dorau, Lukasz
0 siblings, 0 replies; 27+ messages in thread
From: Dorau, Lukasz @ 2013-09-23 14:11 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Patelczyk, Maciej, Jiang, Dave, JBottomley@parallels.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, intel-linux-scu
On Sunday, September 22, 2013 12:28 AM Peter Senna Tschudin <peter.senna@gmail.com> wrote:
>
> The variable success is only assigned the values true and false.
> Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> identifier b;
> @@
> - T
> + bool
> b = ...;
> ... when any
> b = \(true\|false\)
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/scsi/isci/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c
> index 13098b0..26f8e5c 100644
> --- a/drivers/scsi/isci/port.c
> +++ b/drivers/scsi/isci/port.c
> @@ -174,7 +174,7 @@ static void isci_port_link_up(struct isci_host *isci_host,
> {
> unsigned long flags;
> struct sci_port_properties properties;
> - unsigned long success = true;
> + bool success = true;
>
> dev_dbg(&isci_host->pdev->dev,
> "%s: isci_port = %p\n",
> --
> 1.8.3.1
Acked-by: Lukasz Dorau <lukasz.dorau@intel.com>
^ permalink raw reply [flat|nested] 27+ messages in thread