Re: [RFC PATCH] fpga: Introduce new fpga subsystem

Greg Kroah-Hartman
2013-09-24T22:18:05Z

On Tue, Sep 24, 2013 at 11:22:54AM -0500, Alan Tull wrote:
> Yes, I could see /sys/class/fpga/fpga0/image.rbf/loading and 'data' and
> a few others (If I was requesting to load 'image.rbf'). It's a nice
> interface.
>
> I just used the linux/Documentation/firmware_class/hotplug-script
> without modifications.
>
> To enable it:
>
> * cp linux/Documentation/firmware_class/hotplug-script /lib/udev/
>
> * chmod 755 /lib/udev/hotplug-script
>
> * Add this udev rule:
> SUBSYSTEM=="firmware", ACTION=="add", RUN+="/lib/udev/hotplug-script"
>
> * Check that there aren't other 'firmware' udev rules to get in the
> way.

Hm, don't do that, all "modern" distros will not do firmware loading
through udev anymore, so please don't try to add it back in. The kernel
handles the loading of the firmware directly, with no need to call any
usermodehelper program at all.

> * Add your firmware files to /usr/lib/hotplug/firmware/ or change that
> path in hotplug-script to point to where your firmware files.
>
> The default hotplug-script doesn't do anything special (that the kernel
> couldn't do by itself). What's great is that it could call another
> script that adds headers or does whatever other special un-gzipping or
> other massaging that the firmware image needs before it gets loaded.

Only if you need to do something "special" like this could it justify
not using the in-kernel firmware loader. Also note that I think future
versions of udev will have the udev firmware loader removed entirely, so
watch out for that.

thanks,

greg k-h