From: Toshi Kani <toshi.kani@hp.com>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Jiang Liu <jiang.liu@huawei.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"patches@linaro.org" <patches@linaro.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] Staging / quickstart: remove reduplicate if(acpi_disabled) check
Date: Wed, 25 Sep 2013 17:50:09 -0600 [thread overview]
Message-ID: <1380153009.14046.41.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1379847947-32366-1-git-send-email-hanjun.guo@linaro.org>
On Sun, 2013-09-22 at 11:05 +0000, Hanjun Guo wrote:
> In acpi_bus_register_driver(), there is an if (acpi_disabled) check,
> so the if(acpi_disabled) before it is reduplicate, remove it.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Toshi Kani <toshi.kani@hp.com>
-Toshi
> ---
> drivers/staging/quickstart/quickstart.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
> index 4247d60..9f6ebdb 100644
> --- a/drivers/staging/quickstart/quickstart.c
> +++ b/drivers/staging/quickstart/quickstart.c
> @@ -390,10 +390,6 @@ static int __init quickstart_init(void)
> {
> int ret;
>
> - /* ACPI Check */
> - if (acpi_disabled)
> - return -ENODEV;
> -
> /* ACPI driver register */
> ret = acpi_bus_register_driver(&quickstart_acpi_driver);
> if (ret)
prev parent reply other threads:[~2013-09-25 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 11:05 [PATCH] Staging / quickstart: remove reduplicate if(acpi_disabled) check Hanjun Guo
2013-09-25 23:50 ` Toshi Kani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380153009.14046.41.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=jiang.liu@huawei.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox