From: Andi Kleen <andi@firstfloor.org>
To: acma@infradead.org
Cc: peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, jolsa@redhat.com
Subject: perf, x86: Add last TSX PMU code for Haswell v3
Date: Mon, 30 Sep 2013 14:58:57 -0700 [thread overview]
Message-ID: <1380578343-31301-1-git-send-email-andi@firstfloor.org> (raw)
[This has kernel and user parts.
Both sides have been reviewed now, so hopefully it's good
to merge.]
[v2: Address Peter's feedback for the kernel parts]
[v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code]
Note this also needs the separately posted
64bit comparison fix to correctly report abort codes.
This is currently the last part of the TSX PMU code,
just adding the left over bits:
This adds some changes to the user interfaces.
I'll send patches for the manpage separately.
- Report the transaction abort flags to user space
using a new field, and add the code to display them.
This is used to classify abort types, also fairly
important for tuning as it guides the tuning process,
together with the abort weight that was added earleir.
[3 patches, generic, x86, user tools]
- Add support for reporting the two new TSX LBR flags: in_tx
and abort_tx. The code to handle the LBRs was already
added earlier, this just adds the code to report,
filter and display them.
- Add a workaround for a Haswell issue that it reports
an extra LBR record for every abort. We just filter
those out in the kernel.
Open perf TSX issues left:
- Revisit automatic enabling of precise for tx/el-abort
- Need to fix the sort handling in the user tools
to actually sort on other fields
- The aggregated LBR display in the user tools is not
very useful for transactions, need a way to report them
in a histogram like backtraces.
- May want some shortcut options for
record --transaction --weight / report --sort symbol,transaction,weight
-Andi
next reply other threads:[~2013-09-30 21:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 21:58 Andi Kleen [this message]
2013-09-30 21:58 ` [PATCH 1/6] perf, core: Add generic transaction flags v5 Andi Kleen
2013-09-30 21:58 ` [PATCH 2/6] perf, x86: Add Haswell specific transaction flag reporting v5 Andi Kleen
2013-09-30 21:59 ` [PATCH 3/6] perf, tools: Support sorting by in_tx, abort branch flags v3 Andi Kleen
2013-09-30 21:59 ` [PATCH 4/6] perf, tools: Add abort_tx,no_tx,in_tx branch filter options to perf record -j v3 Andi Kleen
2013-09-30 21:59 ` [PATCH 5/6] perf, tools: Add support for record transaction flags v5 Andi Kleen
2013-09-30 21:59 ` [PATCH 6/6] perf, x86: Suppress duplicated abort LBR records v2 Andi Kleen
2013-10-01 7:22 ` perf, x86: Add last TSX PMU code for Haswell v3 Peter Zijlstra
2013-10-01 7:31 ` Andi Kleen
2013-10-01 8:04 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380578343-31301-1-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acma@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox